fill an array in imbricated for loops

Question

I have 2 arrays of Member - one filled, the other not. I have a list which contains all members. I need to fill the second array with member who are not in the first array.

I tried this , but i got an outboundexception ( i am very bad with pure algorithmic :( )

Member[] busyMember= getBusyMember();
List<Team> allMembers= new ArrayList<Team>(jsonParsed.getAllElement());
Member[] availableMembers= new Member[allMembers.size()-busyMembers.length];


            for (int i= 0; i<allMembers.size(); i++) {
                Team t = allMembers.get(i);
                long memberId = t.getMember().getId();
                for (int j= 0 ; j<busyMember.length; j++) {
                    if (memberId != busyMember[j].getId()) {
                        availableMembers[i]=t.getMember();
                        //outboundexception here

                    }
                }

            }

Thank you very much for your help

Why arrays? Use sets and lists and you won't have these issues... Every second collections question seems to be on operating with arrays where standard collections would turn the problem into a trivial one. Sigh.... The way you ask your question cries for "do not use arrays" — Oleg Sklyar
– Oleg Sklyar, Commented Jan 9, 2014 at 19:19
@OlegS. I know it s much easier to treat with Collections instead arrays but in my case it's an instruction who i must respect :( — ulquiorra
– ulquiorra, Commented Jan 9, 2014 at 20:30

Alexis C. · Accepted Answer · 2014-01-09 19:45:16Z

3

I would just use Lists and the removeAll method. If you really need an array, you can always call the method toArray(T[]) on the resulting list.

List<Member> busyMember= Arrays.asList(getBusyMember());
List<Team> allMembers= new ArrayList<Team>(jsonParsed.getAllElement());
List<Member> availableMembers = new ArrayList<Member>();
for(Team t : allMembers){
    availableMembers.add(t.getMember());
}
availableMembers.removeAll(busyMember);

edited Jan 9, 2014 at 19:45

answered Jan 9, 2014 at 19:21

Alexis C.

94.3k22 gold badges173 silver badges179 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ulquiorra Over a year ago

Thank you for your help. Unfortunately I have to work with arrays because it is the instruction that was given to me. But i will opt for your solution and call toArray méthod

PNS · Accepted Answer · 2014-01-09 19:17:50Z

2

Assuming that allMembers has more elements than busyMember, you just need to change the statement

for (int i= 0; i<allMembers.size(); i++)

to

for (int i= 0; i<availableMembers.size(); i++)

There are other changes that you would need to do for consistency, but this is another discussion :-)

answered Jan 9, 2014 at 19:17

PNS

20.1k33 gold badges102 silver badges145 bronze badges

3 Comments

Rohit Jain Over a year ago

While this will resolve the current exception, this will result in another logical issue.

ulquiorra Over a year ago

@PNS Thank you for your help . Indeed , this resolve my problem , but it doesn't read all datas of allMembers array( because it's limited to availableMembers.size())

PNS Over a year ago

Which means you need to do the revision, as per ZouZou's suggestion, or manually keep track of the correct index values.

Collectives™ on Stack Overflow

fill an array in imbricated for loops

2 Answers 2

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related