Why is my rails simple validation not working

Question

I have a very basic rails app. I am playing around with validation.

Controller

class PagesController < ApplicationController
  def new
    @user = User.new
  end
  def edit
    @user = User.new(:state => params[:state], :country => params[:country])
    @user.save
  end
end

Model

class User < ActiveRecord::Base
    validates_presence_of :country
    validates_presence_of :state
end

Views/pages/edit.html.erb

<% form_for :user, @user, :url => { :action => "edit" } do |f| %>
  <%= f.text_field :country %>
  <%= f.text_field :state %>
  <%= submit_tag 'Create' %>
<% end %>

All I want to do is click Create when I have not entered anything and then have a validation come up and list the required fields. I've read some tutorials and they make it so simple. Why can't I get this to work? what am i doing wrong? When i create a scaffold then it works ok but that generates a scaffold.css in public/stylesheets. W/out scaffold right now i have no stylesheet in the public folder.

Jaime Bellmyer · Accepted Answer · 2010-01-26 02:57:39Z

2

you're sending the form to the "edit" action, which doesn't do any processing. You need it to go to the "create" action, which should look something like this:

def create
  @user = User.new(params[:user])

  if @user.save
    flash[:notice] = 'Your user was successfully created.'
    redirect_to users_path
  else
    render :action => 'edit'
  end
end

Your form_for line can be short and sweet. Also, you need to call error_messages to get the auto-generated list of errors:

<% form_for @user do |f| %>
  <%= f.error_messages %>
  ...other fields go here...
<% end %>

answered Jan 26, 2010 at 2:57

Jaime Bellmyer

23.4k7 gold badges55 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ben Over a year ago

It's important for the OP to understand that new & create work together to create an new resource (new presents the form, create saves it to the database), and edit & update work together in the same way for existing resources.

joshn Over a year ago

in your answer...form_for @user needs to be form_for :user

Jaime Bellmyer Over a year ago

Actually, form_for @user works fine for me - that's how all of my forms are setup. Odd...

General Grievance · Accepted Answer · 2022-11-03 14:58:40Z

0

See Rails conditional validation: if: doesn't working

It seems like you think validates ... if: works differently as it actually does. This line

validates :to_id, presence: true, if: :from_different_to?

translates to validate that the to_id is present if the from_different_to method returns true. When from_different_to evaluates to false then do not validate.

edited Nov 3, 2022 at 14:58

General Grievance

5,12039 gold badges40 silver badges60 bronze badges

answered Aug 27, 2022 at 14:38

Edward Casanova

1,09412 silver badges20 bronze badges

Collectives™ on Stack Overflow

Why is my rails simple validation not working

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related