Ember.js ArrayController error

Question

I am trying to test the following sample Ember.js code but I am always getting the following error displayed in the Chrome browser console:

Uncaught TypeError: Property '_super' of object [object Object] is not a function

Code:

MovieTracker.moviesController = Ember.ArrayController.create({
       content: [],
       init: function(){
           this._super();
           var list = [
               MovieTracker.Movie.create({
                   title: 'Movie 1',
                   rating: 4 }),
               MovieTracker.Movie.create({
                   title: 'Movie 2',
                   rating: 5
               })];
           this.set('content', list);
       }
});

I am using Ember-1.3.2.js

can someone please tell me what I am missing here? and how to solve this error?

New error message after changing .create to .extend as recommended by @kingpin2k

TypeError: Object function () { if (!wasApplied) { Class.proto(); // prepare prototype... } o_defineProperty(this, GUID_KEY, undefinedDescriptor); o_defineProperty(this, '_super', undefinedDescriptor); var m = meta(this), proto = m.proto; m.proto = this; if (initMixins) { // capture locally so we can clear the closed over variable var mixins = initMixins; initMixins = null; this.reopen.apply(this, mixins); } if (initProperties) { // capture locally so we can clear the closed over variable var props = initProperties; initProperties = null; var concatenatedProperties = this.concatenatedProperties; for (var i = 0, l = props.length; i < l; i++) { var properties = props[i]; Ember.assert("Ember.Object.create no longer supports mixing in other definitions, use createWithMixins instead.", !(properties instanceof Ember.Mixin)); if (typeof properties !== 'object' && properties !== undefined) { throw new Ember.Error("Ember.Object.create only accepts objects."); } if (!properties) { continue; } var keyNames = Ember.keys(properties); for (var j = 0, ll = keyNames.length; j < ll; j++) { var keyName = keyNames[j]; if (!properties.hasOwnProperty(keyName)) { continue; } var value = properties[keyName], IS_BINDING = Ember.IS_BINDING; if (IS_BINDING.test(keyName)) { var bindings = m.bindings; if (!bindings) { bindings = m.bindings = {}; } else if (!m.hasOwnProperty('bindings')) { bindings = m.bindings = o_create(m.bindings); } bindings[keyName] = value; } var desc = m.descs[keyName]; Ember.assert("Ember.Object.create no longer supports defining computed properties.", !(value instanceof Ember.ComputedProperty)); Ember.assert("Ember.Object.create no longer supports defining methods that call _super.", !(typeof value === 'function' && value.toString().indexOf('._super') !== -1)); Ember.assert("actions must be provided at extend time, not at create " + "time, when Ember.ActionHandler is used (i.e. views, " + "controllers & routes).", !((keyName === 'actions') && Ember.ActionHandler.detect(this))); if (concatenatedProperties && indexOf(concatenatedProperties, keyName) >= 0) { var baseValue = this[keyName]; if (baseValue) { if ('function' === typeof baseValue.concat) { value = baseValue.concat(value); } else { value = Ember.makeArray(baseValue).concat(value); } } else { value = Ember.makeArray(value); } } if (desc) { desc.set(this, keyName, value); } else { if (typeof this.setUnknownProperty === 'function' && !(keyName in this)) { this.setUnknownProperty(keyName, value); } else if (MANDATORY_SETTER) { Ember.defineProperty(this, keyName, null, value); // setup mandatory setter } else { this[keyName] = value; } } } } } finishPartial(this, m); this.init.apply(this, arguments); m.proto = proto; finishChains(this); sendEvent(this, "init"); } has no method 'get'

What your test? And MoviesController should be capitalized

Kingpin2k
– Kingpin2k

2014-02-15 22:44:17 +00:00
Commented Feb 15, 2014 at 22:44 — Kingpin2k
– Kingpin2k, Commented Feb 15, 2014 at 22:44
MovieTracker.moviesController.get('length');

MChan
– MChan

2014-02-15 22:47:15 +00:00
Commented Feb 15, 2014 at 22:47 — MChan
– MChan, Commented Feb 15, 2014 at 22:47

uniacid · Accepted Answer · 2014-05-01 22:03:53Z

2

I was having the same issue as I'm following the same book as well, finally figured out why this wasn't working on Ember 1.5.1:

Should use capital for MoviesController instead of moviesController as mentioned.
Should be extending off Ember.ArrayController not creating off of it.
Don't use this._super()

So the following code should work for anyone interested...

MovieTracker.MoviesController = Ember.ArrayController.extend({
content: [],
init: function() {
    var list = [
        MovieTracker.Movie.create({
            title: 'Movie 1',
            rating: 4
        }),
        MovieTracker.Movie.create({
            title: 'Movie 2',
            rating: 5
        })];

    this.set('content', list);
}});

answered May 1, 2014 at 22:03

uniacid

211 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mahmoud Metwally · Accepted Answer · 2014-02-16 09:01:39Z

1

I had the same problem before and after a lot of trials the problem was in the controller name spelling and case. For example (based on your question code) calling:

MovieTracker.moviesController.get('length');

while the name of the controller is MoviesController with a capital M will give you this error. So try double checking your code, make sure you have the correct name with correct case.

It is also a good practice to keep controller name with capital M as @kingpin2k recommended

answered Feb 16, 2014 at 9:01

Mahmoud Metwally

9901 gold badge10 silver badges25 bronze badges

Comments

Kingpin2k · Accepted Answer · 2014-02-15 22:47:11Z

-1

MoviesController should be capitalized and you should be extending Ember.ArrayController not creating it.

MovieTracker.MoviesController = Ember.ArrayController.extend({
       content: [],
       init: function(){
           this._super();
           var list = [
               MovieTracker.Movie.create({
                   title: 'Movie 1',
                   rating: 4 }),
               MovieTracker.Movie.create({
                   title: 'Movie 2',
                   rating: 5
               })];
           this.set('content', list);
       }
});

answered Feb 15, 2014 at 22:47

Kingpin2k

47.4k10 gold badges80 silver badges97 bronze badges

9 Comments

MChan Over a year ago

Changing to extend created a new error: TypeError: Object function () { if (!wasApplied) { Class.proto(); // prepare prototype... } o_defineProperty(this, GUID_KEY, undefinedDescriptor);...way too long to paste all here

Kingpin2k Over a year ago

please add the error to your original question, and show how you're creating the controller for the test.

MChan Over a year ago

I already posted how I am calling the controller from the console

MChan Over a year ago

Error caused by changing to .extend added to the question

Kingpin2k Over a year ago

You're mistaking two things here. You should be using extend when defining a controller. That does not create it. So when I told you to switch to extend, that just created a new type of controller. You still need to then create it.

|

code0110 · Accepted Answer · 2014-05-06 02:06:49Z

-1

'create' works perfect for the example in this book. Below code worked for me

MovieTracker.MoviesController = Ember.ArrayController.create({
content: [],
init: function(){
var list = [    
        MovieTracker.Movie.create({
            title: 'The Avengers',
            rating: 4
        }),
        MovieTracker.Movie.create({
            title: 'Spiderman',
            rating: 5
        })];
    this.set('content', list);
}       
});

versions

DEBUG: Ember : 1.5.0 DEBUG: Handlebars : 1.1.2 DEBUG: jQuery : 1.10.2

Ember Debugger Active VM2276:161 MovieTracker.MoviesController.get('length');

2

answered May 6, 2014 at 2:06

code0110

1

2 Comments

Rob Watts Over a year ago

Can you highlight how your code is different than the code in the question? It looks the same to me.

code0110 Over a year ago

extend 'vs' create , I used create not extend

Collectives™ on Stack Overflow

Ember.js ArrayController error

4 Answers 4

Comments

Comments

9 Comments

versions

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

9 Comments

versions

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related