Function not called via javascript in href

Question

I used a code that I found in the web and then changed a little thing:

<script type="text/javascript">
    var foodList = [];

    function addToFood (addFood) {
        alert(addFood);
        //foodList.push(addFood);
        //for (i = 0; i < foodList.length; i++) {
        //    var newFood = "<a href='#' onClick='removeRecord(" + i + ");'>X</a> " + foodList[i] + " <br>";
        //};
        //document.getElementById('foods').innerHTML += newFood;
    }
</script>

At this moment I only want to alert the parameter on addToFood. The function should be called:

echo "<a href='javascript:addToFood(". $zeile1['TITLE'] .");' class='band-head'>Add</a>";

this line shows how I add an <a> with the javascript in the href. The php render the right line but the addToFood is never called.

Have a look at the online Demo: http://anthraxx.sytes.net/ maybe it can help you more then me. The error I get via Google Chrome: Uncaught SyntaxError: Unexpected identifier But just can't figure that unexpected identifier out.

Thanks

You have a JavaScript error. Look at the JavaScript, don't look at the PHP that generates the JavaScript. Figure out what the problem and what you need to change about the JS to fix it, then look at the PHP. — Quentin
– Quentin, Commented Feb 18, 2014 at 12:46
echo '<a href="javascript:addToFood('. $zeile1['TITLE'] .');" class="band-head">Add</a>'; replace — Netzach
– Netzach, Commented Feb 18, 2014 at 14:13

Eric · Accepted Answer · 2014-02-18 12:51:44Z

4

You need to wrap the $zeile1['TITLE'] inside a string, as such:

echo "<a href='javascript:addToFood(\"". $zeile1['TITLE'] ."\");' class='band-head'>Add</a>";

You can see that I added escaped quotes \" after the opening parenthesis, and before the ending one, in the JS-call. Otherwise it will try to pass an variable to the function, instead of a string.

Why escaped? That is because you are echo:ing it with PHP. If I didn't escape the quote, the PHP would interpret it as I was ending the string, which is not what we want. I want to put the quotes in there as inline-code.

edited Feb 18, 2014 at 12:51

answered Feb 18, 2014 at 12:46

Eric

19k2 gold badges36 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mahmoud.Eskandari · Accepted Answer · 2014-02-18 12:51:54Z

1

Just scope your vaiable between ' ' or " " ,When you don't scope String's ,javascript read it like Var.

answered Feb 18, 2014 at 12:51

Mahmoud.Eskandari

1,4883 gold badges22 silver badges37 bronze badges

Comments

Mandeep Singh · Accepted Answer · 2014-02-18 12:53:41Z

1

You need to escape the $zeile1['TITLE'], thats true and you can do that by using following line -

    echo "<a href='javascript:addToFood(\"". $zeile1['TITLE'] ."\");' class='band-head'>Add</a>";

This is working.

answered Feb 18, 2014 at 12:53

Mandeep Singh

1,0039 silver badges9 bronze badges

Comments

Md Mahmudul Haque Fahim · Accepted Answer · 2014-02-18 12:53:58Z

1

try this

    echo '<a href="javascript:addToFood(\''.$zeile1['TITLE'].'\');" class="band-head">Add</a>';

answered Feb 18, 2014 at 12:53

Md Mahmudul Haque Fahim

2834 silver badges17 bronze badges

Comments

Codrutz Codrutz · Accepted Answer · 2014-02-18 12:54:22Z

1

Replace :

echo "<a href='javascript:addToFood(". $zeile1['TITLE'] .");' class='band-head'>Add</a>";

With:

echo "<a href='javascript:addToFood(\"". $zeile1['TITLE'] ."\");' class='band-head'>Add</a>";

answered Feb 18, 2014 at 12:54

Codrutz Codrutz

4805 silver badges15 bronze badges

Collectives™ on Stack Overflow

Function not called via javascript in href

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related