PHP class extends Singleton pattern

Question

class singleton:

class Singleton
{
    private static $_myself;

    private function __construct(){}

    public static function getInstance()
    {
        if(!isset(self::$_myself))
        {
            $obj = __CLASS__;
            self::$_myself = new $obj;
        }
        return self::$_myself;
    }
}

my class:

 class MyApp extends Singleton
    {
        public function show()
        {
            echo 'show';
        }
    }
    MyApp::getInstance()->show();

but not working, this error: Call to undefined method Singleton::show() somebody can help me?

This pattern creates lots of tight coupling, which makes your application harder to evolve, test, and re-use. The singleton pattern is fine (one instance used in lots of places), but this very common static function pattern causes a lot of problems. Please use a dependency injection framework. After looking around a bit, PHP-DI looks nice: php-di.org — Hans
– Hans, Commented Feb 24, 2014 at 18:08

h2ooooooo · Accepted Answer · 2014-02-24 18:00:08Z

3

Because you're returning a Singleton class (as you can see by your error), but should be returning a MyApp class. You can do this by using the late static binding method get_called_class() introduced in PHP 5.3:

public static function getInstance()
{
    if(!isset(self::$_myself))
    {
        //__CLASS__ = Singleton | get_called_class() = MyApp
        $obj = get_called_class(); 
        self::$_myself = new $obj;
    }
    return self::$_myself;
}

answered Feb 24, 2014 at 18:00

h2ooooooo

39.6k8 gold badges70 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:20:57Z

2

self returns the actual class instance (Singleton in this case), so there is no method show. But you could use static instead of self (Differences) and change $_myself from private to protected so it is accessible in child classes.

class Singleton
{
    protected static $_myself;

    private function __construct(){}

    public static function getInstance()
    {
        if(!isset(static::$_myself))
        {
            static::$_myself = new static;
        }
        return static::$_myself;
    }
}

edited May 23, 2017 at 12:20

CommunityBot

11 silver badge

answered Feb 24, 2014 at 18:07

PascalKleindienst

1681 silver badge8 bronze badges

Comments

Daniel W. · Accepted Answer · 2014-02-24 18:03:22Z

-1

The problem is in

$obj = __CLASS__;
self::$_myself = new $obj;

You create a new instance of the class Singleton, not of the class MyApp, so the method is not available.

Now h2ooooooo was faster with his answer than I edited, see his answer regarding what to put instead of __CLASS__.

edited Feb 24, 2014 at 18:03

answered Feb 24, 2014 at 17:56

Daniel W.

32.6k15 gold badges99 silver badges155 bronze badges

Collectives™ on Stack Overflow

PHP class extends Singleton pattern

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related