Recursive javascript exceeding call stack size

Question

I'm writing an angularjs controller that's is polling for stuff. The polling function calls itself with a timeout. Below are two examples of this. The first exceeds the call stack size, but the second example does not. Why is that?

Example 1 (Exceeds call stack size):

myApp.controller('Ctrl1', function($scope, $timeout) {
   $scope.value = 1;
    function poll() {
        $scope.value++;
        $timeout(poll(), 1000);
    }
   poll();
});

Example 2 (works fine):

myApp.controller('Ctrl1', function($scope, $timeout) {
   $scope.value = 1;
    function poll(){
        $timeout(function() {
            $scope.value++;
            poll();
        }, 1000);
    };     
   poll();
});

Denys Séguret · Accepted Answer · 2014-02-28 15:09:24Z

6

You're not passing the function but its returned value (undefined). Which means you immediately call it and as it calls itself, well, here's your stack overflow.

Change

$timeout(poll(), 1000);

to

$timeout(poll, 1000);

As an aside, you can rewrite

function poll() {
    $scope.value++;
    $timeout(poll, 1000);
}
poll();

in a slightly more elegant manner which doesn't pollute the external scope :

(function poll() {
    $scope.value++;
    $timeout(poll, 1000);
})();

answered Feb 28, 2014 at 15:09

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vjeko Babic · Accepted Answer · 2015-08-28 11:38:21Z

0

Put function in side $timeout(): Sou make it like:

$timeout(function(){

   pool();
   // You can also add some other things here...

}, 1000):

answered Aug 28, 2015 at 11:38

Vjeko Babic

273 bronze badges

Collectives™ on Stack Overflow

Recursive javascript exceeding call stack size

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related