How can i upload multiple files in node.js?

Question

I need help in upload multiple files using node.js upload file reader.

I am using the fs = require('fs'). I have problem in choose two files,only one file only write in upload directory.

This is my backend

var files = req.files.files[0];
for (var i = 0; i < files.length; i++) {    
  file = files[i];
  fs.readFile(files[i].path, function(error, data) {
    // console.log( files[i].path ) ,here displayed two same both
    fs.writeFile(uploadDirectory() + newFileName, data, function(error) {
    });
  });
}

Please help me. what is the problem in my code. Thanks.

possible duplicate of PhantomJS Node - page.open - cannot keep track of multiple pages — TimWolla
– TimWolla, Commented Mar 11, 2014 at 14:27

suish · Accepted Answer · 2014-03-11 17:55:46Z

1

You should avoid using files[i] in asynchronous function's callback which is directly written inside of for-loop. the reason why console.log( files[i].path ) displays same thing twice is because when the code is loaded,the for-loop has already done. so you always get the last element of the array.

the easiest way to fix that is making a new scope(function)

for (var i = 0; i < files.length; i++) {    
  readAndWriteFile(files[i]);
}

var readAndWriteFile = function(file){
    fs.readFile(file.path, function(error, data) {
    // console.log( file.path ) displays what you expect.
    fs.writeFile(/* define new file name */, data, function(error) {
    });
  });
}

answered Mar 11, 2014 at 17:55

suish

3,3631 gold badge19 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How can i upload multiple files in node.js?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related