Perl Find and Replace Not working with values from array

Question

For this script, I am pulling a csv file that includes what needs to be found and what the replacement is. Those values, $pattern1 and $replacement1 are then inserted into a find & replace function. Ideally this will take the csv key file & do an inplace replacement of the raw data file.

use English;
use strict;
use warnings;

sub inplace_sanitize {
my ( $datafile, $pattern1, $replacement1 ) = @_;
local @ARGV = ( $datafile ),
  my $INPLACE_EDIT = '.back';
while ( <> ) {
s/\Q$pattern1/$replacement1/g;
#print;
}
}

sub main 
{
# Select Key for Find & Replace
my $filename = 'stmre_fr_key.csv';

open(INPUT, $filename) or die "Cannot open $filename";

# Read the header line.
my $line = <INPUT>;

# Read the lines one by one.
while($line = <INPUT>)
{
    chomp($line);

    #Split & Assign
    my ($replacement1, $pattern1) = split(',', $line);

    # Select Data File
    my $datafile = 'rawdata.csv';

    #Find & Replace Data File
    &inplace_sanitize( $datafile, $pattern1, $replacement1 );
}   
}
close(INPUT);
main();

So this is not working, as it doesn't perform the replacement. Without the inplace_sanitizecall it prints out the $replacement1 & $pattern1 correctly. The inplace_sanitize works by itself if you define $replacement1 = 'replace'; and $pattern1 = 'find';. But together there it doesn't work. Any ideas?

Samples:

$replacement1 = '7306e005';
$pattern1 = 'leighs_satcon011016001_00753b94';

stmre_fr_key.csv:

find,replace
leighs_satcon011016001_00753b94,7306e005
leighs_satcon011016001_00753b95,7306e006
.
.
.

Show some sample input and output. Is your mapping file really of the form replacement,pattern, with replacement on the left? — ThisSuitIsBlackNot
– ThisSuitIsBlackNot, Commented Mar 13, 2014 at 22:09
's/\Q$pattern1\E/\Q$replacement1\E/g;' try that, the importance here is that also ending the \Q with an \E, and your doing it for both. I stole this from Eclipse complete-ant-cmd.pl script :) — alexmac
– alexmac, Commented Mar 13, 2014 at 22:29
Your use of my $INPLACE_EDIT looks fishy. should be local $INPLACE_EDIT — Miller
– Miller, Commented Mar 13, 2014 at 22:45

Miller · Accepted Answer · 2014-03-13 22:51:18Z

2

You're use of my $INPLACE_EDIT is your problem. You want to effect the global variable:

local $INPLACE_EDIT = '.back';

The same way you're treating @ARGV

answered Mar 13, 2014 at 22:51

Miller

35.3k4 gold badges42 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

snoop Over a year ago

Excellent, although for some reason its deleting all the content in that and the .back file.

Miller Over a year ago

Uncomment your print statement.

Collectives™ on Stack Overflow

Perl Find and Replace Not working with values from array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related