php mysql code won't echo

Question

I got the following code:

    if(isset($_SESSION['user_id'])) { $query = "SELECT * FROM watchlist,movies WHERE watchlist.page=movies.id AND userid=". $_SESSION['user_id']; 
    $result = mysql_query($query) or die('Query failed: ' . mysql_error());

    while( $row = mysql_fetch_assoc($result) )
      {
        echo '<div id="watchlist">';
            echo '<a href="watch.php?id='.$row['page'].'"><img src="http://nocmmnt.com/posters/'.$row['imdb_id'].'.jpg" height="217" width="154"></a><br>';
            echo '<span style="float:right;"><a href="delete.php?wid='.$row['wid'].'"><img src="image/close_delete.png" width="20"></a></span><a href="watch.php?id='.$row['page'].'">'.$row['title'].'</a><br>';  
            echo "</div>";
      }
    elseif(empty($row)) {
        echo "You dont have any movies in your watchlist!";
    }

My problem is that is doesnt echo when its empty how can I fix that?

You want to echo when no result found? if yes then what you want to print? use mysql_num_rows for checking empty rows. — Rohit Nigam
– Rohit Nigam, Commented Apr 4, 2014 at 8:47

Hanky Panky · Accepted Answer · 2014-04-04 08:51:48Z

1

elseif(empty($row)) {

That's wrong conditional structure, an elseif must come after an if block or another elseif.

How can that code not generate a parse error for you?

Parse error: syntax error, unexpected T_ELSEIF on line 13

Also, as others mentioned, simply check for row count being 0

if(mysql_num_rows($result)==0)

answered Apr 4, 2014 at 8:51

Hanky Panky

46.9k9 gold badges76 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

echo_Me · Accepted Answer · 2014-04-04 08:49:47Z

0

Try that :

   if(mysql_num_rows($result) == 0)
  { echo "You dont have any movies in your watchlist!"; }
  else{
  while( $row = mysql_fetch_assoc($result) )
  {
    echo '<div id="watchlist">';
        echo '<a href="watch.php?id='.$row['page'].'"><img src="http://nocmmnt.com/posters/'.$row['imdb_id'].'.jpg" height="217" width="154"></a><br>';
        echo '<span style="float:right;"><a href="delete.php?wid='.$row['wid'].'"><img src="image/close_delete.png" width="20"></a></span><a href="watch.php?id='.$row['page'].'">'.$row['title'].'</a><br>';  
        echo "</div>";
  }

  }

answered Apr 4, 2014 at 8:49

echo_Me

37.2k5 gold badges62 silver badges81 bronze badges

Comments

Abhik Chakraborty · Accepted Answer · 2014-04-04 08:45:55Z

0

You need to use

mysql_num_rows($result)

to check if there are 0 rows or more than that.

answered Apr 4, 2014 at 8:45

Abhik Chakraborty

44.9k6 gold badges56 silver badges63 bronze badges

Comments

Community · Accepted Answer · 2023-11-20 22:45:59Z

0

Checking empty($row) doesn't do what you think it does. What you want to check is mysql_num_rows($result) == 0.

A sidenote - mysql is deprecated in favor of mysqli.

edited Nov 20, 2023 at 22:45

CommunityBot

11 silver badge

answered Apr 4, 2014 at 8:46

Jeff

7994 silver badges14 bronze badges

Comments

opensource-developer · Accepted Answer · 2014-04-04 08:53:38Z

You could modify your code as below, also try to use mysqli instead of mysql

<?php
if(isset($_SESSION['user_id'])) { $query = "SELECT * FROM watchlist,movies WHERE watchlist.page=movies.id AND userid=". $_SESSION['user_id']; 
    $result = mysql_query($query) or die('Query failed: ' . mysql_error());

    $count = mysql_num_rows($result);

    if($count > 0 )
    {
        while( $row = mysql_fetch_assoc($result) )
        {   
            echo '<div id="watchlist">';
            echo '<a href="watch.php?id='.$row['page'].'"><img src="http://nocmmnt.com/posters/'.$row['imdb_id'].'.jpg" height="217" width="154"></a><br>';
            echo '<span style="float:right;"><a href="delete.php?wid='.$row['wid'].'"><img src="image/close_delete.png" width="20"></a></span><a href="watch.php?id='.$row['page'].'">'.$row['title'].'</a><br>';  
            echo "</div>";
        }
    }
    else {
        echo "You dont have any movies in your watchlist!";
    }
}
?>

Collectives™ on Stack Overflow

php mysql code won't echo

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related