php echo not displaying

Question

This code

<?php  echo "Likes: ".$r['votes_up']."&nbsp;"; echo "Dislike: ".$r['votes_down'].""; ?>

Wont post the values from the table for 'votes_up' 'votes_down'
I cant get my head round this! Ive got this exact code working on a different page but it wont on this.
Heres the entire code ....

    <div class="message">
<?php 
$sql = mysql_query("SELECT * FROM threads WHERE id = '" . $_GET['id'] . "'") or die(mysql_error());     
    while($r = mysql_fetch_array($sql))  {
$posted = date("jS M Y h:i",$r['posted']); echo "".$r['author']." &nbsp; $posted";?>
<a href="http://twitter.com/share" class="twitter-share-button" data-count="horizontal" data-text="<?php echo "".$r['message'].""; ?>">
        Tweet</a><script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script>
<div class="message2"><?php echo "".$r['message'].""; }?></div> 
<?php  echo "Likes: ".$r['votes_up']."&nbsp;"; echo "Dislike: ".$r['votes_down'].""; ?>        
</div>
<br/>
<hr>

Can anyone help? its driving me insane

looking at your code, $r is out of scope where you refer to your problem. place that echo inside the while loop — sdolgy
– sdolgy, Commented Jul 12, 2011 at 13:32
ARGHSQLINJECTION why are people still failing at this in 2011?! — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Jul 12, 2011 at 13:32
@Tomalak Geret'kal — Probably (at least partially) due to W3Schools (spit) continuing to teach PHP/SQL without mentioning SQL injection once. — Quentin
– Quentin, Commented Jul 12, 2011 at 13:45

jenovachild · Accepted Answer · 2011-07-12 13:32:38Z

2

Line 8 of your code

<div class="message2"><?php echo "".$r['message'].""; }?></div>

Why is that closing curly brace in there before the closing ?> ?

answered Jul 12, 2011 at 13:32

jenovachild

1,8112 gold badges15 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Niko Efimov · Accepted Answer · 2011-07-12 13:32:41Z

2

You seem to have closed the WHILE loop here:

<div class="message2"><?php echo "".$r['message'].""; }?></div>

Notice the curly bracket.

Therefore, votes_up and votes_down have no values.

answered Jul 12, 2011 at 13:32

Niko Efimov

2,2233 gold badges21 silver badges30 bronze badges

1 Comment

Lightness Races in Orbit Over a year ago

No, they have values. PHP has no block scope. That's not to say that this is correct, but it cannot cause "no values".

JConstantine · Accepted Answer · 2011-07-12 13:41:20Z

1

Your curly bracket is being placed before the last echo statement, therefore the $r variable is out of scope.

Move the } to later in your page like so

<div class="message">
<?php 
    $sql = mysql_query("SELECT * FROM threads WHERE id = '" . mysql_real_escape_string($_GET['id']) . "'") or die(mysql_error());     
    while($r = mysql_fetch_array($sql))
    {
        $posted = date("jS M Y h:i",$r['posted']);
        echo $r['author']." ".$posted;
?>
<a href="http://twitter.com/share" class="twitter-share-button" data-count="horizontal" data-text="<?php echo $r['message']; ?>">
    Tweet</a><script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script>
<div class="message2">
    <?php
        echo $r['message']; 
    ?>
</div> 
    <?php
        echo "Likes: ".$r['votes_up']."&nbsp;";
        echo "Dislike: ".$r['votes_down'];
    } 
    ?>        
</div>
<br/>
<hr>

Also notice the call to mysql_real_Escape_string in the $sql var. this will prevent nasty sql injections

edited Jul 12, 2011 at 13:41

answered Jul 12, 2011 at 13:32

JConstantine

3,9411 gold badge36 silver badges46 bronze badges

1 Comment

Lightness Races in Orbit Over a year ago

No, PHP has no block scope. That's not to say that this is correct, but it cannot cause "no values".

Jules · Accepted Answer · 2011-07-12 13:35:49Z

0

This is because the $r['...'] variable is out of the scope where you place it.

Better way to do it (assuming you only fetch one row:

<?
   $sql = mysql_query("SELECT * FROM threads WHERE id = '" . $_GET['id'] . "'") or die (mysql_error());
   $row = mysql_fetch_assoc($sql);
?>

<div> ... </div>
<?php echo "Likes: " . $row['votes_up'] . " &nbsp;  Dislike: " . $row['votes_down']; ?>

answered Jul 12, 2011 at 13:35

Jules

7,2236 gold badges28 silver badges51 bronze badges

Collectives™ on Stack Overflow

php echo not displaying

4 Answers 4

Comments

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related