Stuck in C# SQL

Question

Hello Every One I am new To C# and SQL can any one tell me where am I wrong. It is not inserting . And not giving any errors.

 SqlConnection myConnection = new SqlConnection("server=SHASHAK\\SQLEXPRESS;" +
                             "Trusted_Connection=yes;" +
                             "database=Abhishek; " +
                             "connection timeout=30");

private void btnShow_Click(object sender, EventArgs e)
{

    try
    {
        //myConnection.Open();
       //// SqlCommand cmd = new SqlCommand("select player_id, player_name , score from player", myConnection);
        SqlCommand cmd = new SqlCommand("INSERT INTO Abhishek (" + "  player_id, player_name " + ") VALUES (" + " @textBox1.Text, @textBox2.Text", myConnection);
       SqlDataAdapter adapter = new SqlDataAdapter(cmd);
       MessageBox.Show("Ok");

        //DataTable dt = new DataTable();
        //adapter.Fill(dt);
        //screen.DataSource = dt;



    }
    catch (SqlException ex)
    {
        MessageBox.Show("You failed!" + ex.Message);
    }
}

you aren't executing the command, and you aren't setting your parameter values. You commented out where you open the connection, which is pretty important — Jonesopolis
– Jonesopolis, Commented Apr 17, 2014 at 18:13
And when you do execute the command you are missing a ) however you really really should be using Parametrized queries — Scott Chamberlain
– Scott Chamberlain, Commented Apr 17, 2014 at 18:15

Habib · Accepted Answer · 2014-04-17 18:53:04Z

4

Try This:

myConnection.Open();
SqlCommand cmd = new SqlCommand("INSERT INTO Abhishek (player_id, player_name)     
             VALUES(@playerid, @playername)", myConnection);
cmd.Parameters.AddWithValue("@playerid",textBox1.Text);
cmd.Parameters.AddWithValue("@playername",textBox2.Text);
int commandStatus = cmd.ExecuteNonQuery();

if(commandStatus > 0)
      MessageBox.Show("Row inserted Successfully!");
else
      MessageBox.Show("Row Insertion Failed!");

edited Apr 17, 2014 at 18:53

Habib

224k30 gold badges420 silver badges446 bronze badges

answered Apr 17, 2014 at 18:18

Sudhakar Tillapudi

26.3k5 gold badges43 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Abhishek Sharma Over a year ago

its giving error "You failed " syntax error @player"

Sudhakar Tillapudi Over a year ago

@AbhishekSharma: sorry i missed to specify the exact parameter names , please check my edit now

Abhishek Sharma Over a year ago

giving error " must declare scaler variable @playerid"

Abhishek Sharma Over a year ago

again an error near "int commandStatus = cmd.ExecuteNonQuery();"

Abhishek Sharma Over a year ago

SQl unhandled "Incorrect syntax near '@playername'.

Habib · Accepted Answer · 2014-04-17 18:51:26Z

3

Few issues with your code.

You are trying to parameterized query but you are not passing any parameter to command
You need to use using statement with your connection and command object.
catch System.Exception after SqlException to catch any other exception.
You are not executing your command.

Your code could be on the following lines:

SqlConnection myConnection = new SqlConnection("server=SHASHAK\\SQLEXPRESS;" +
                   "Trusted_Connection=yes;" +
                   "database=Abhishek; " +
                   "connection timeout=30");
private void btnShow_Click(object sender, EventArgs e)
{
    try
    {
        using (myConnection)
        {
            using (SqlCommand cmd = new SqlCommand("INSERT INTO player (player_id, player_name) VALUES (@playerid, @playername)", myConnection))
            {
                cmd.Parameters.AddWithValue("@playerid", textBox1.Text);
                cmd.Parameters.AddWithValue("@playername", textBox2.Text);
                myConnection.Open();
                cmd.ExecuteNonQuery();
            }
        }
    }
    catch (SqlException ex)
    {
        MessageBox.Show("You failed!" + ex.Message);
    }
    catch (Exception ex)
    {
        //Show message / log
    }
}

Consider using names which reflect their values. e.g. txtPlayerID and txtPlayerName for textBox1 and textBox2 respectively.

edited Apr 17, 2014 at 18:51

answered Apr 17, 2014 at 18:19

Habib

224k30 gold badges420 silver badges446 bronze badges

9 Comments

Scott Chamberlain Over a year ago

int.Parse is not strictly nessesary, Sql will attempt to convert it for you when it performs the insert. Just be aware that it might not use your indexes in some special conditions depending on which variable (yours or the column you are doing something to) gets automatically cast.

Abhishek Sharma Over a year ago

@Habib Its giving me an error .. Invalid Object Abhishek

Habib Over a year ago

@AbhishekSharma, what is your table name ? is it same as your Database name ?

Habib Over a year ago

@AbhishekSharma, modified my code, your code in question had INSERT INTO Abhishek, it should be INSERT INTO PLAYER. Try the edited code in answer.

Abhishek Sharma Over a year ago

myConnection.Open(); SqlCommand cmd = new SqlCommand("select player_id, player_name , score from player", myConnection); SqlDataAdapter adapter = new SqlDataAdapter(cmd); DataTable dt = new DataTable(); adapter.Fill(dt); screen.DataSource = dt;

|

Collectives™ on Stack Overflow

Stuck in C# SQL

2 Answers 2

5 Comments

9 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

9 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related