Unexpected PHP Parse Error

Question

I realise that the answer to this question is probably going to be simply obvious, but I am stumped.

I've created a class that uses Jeremy Kendall's Password Validator (https://github.com/jeremykendall/password-validator) called Hash. However, when the class gets called I get:

Parse error: syntax error, unexpected '}' in /home/james/Projects/REC/htdocs/classes/Hash.class.php on line 24.

The code in Hash.class.php that it is having issues with is:

private $validationCallback;

public function __construct(){
    $this->validationCallback = function($credential, $passwordHash){
        if (has('md5', $credential) === $passwordHash) {
            return true;
        }
        return false;
    }
}

Line 24 is the final '}'. Any help would be greatly appreciated.

Thanks.

MD5? Lordie, do they still use that in the 21st century?

Funk Forty Niner
– Funk Forty Niner

2014-04-25 11:58:14 +00:00
Commented Apr 25, 2014 at 11:58 — Funk Forty Niner
– Funk Forty Niner, Commented Apr 25, 2014 at 11:58

Brandon - Free Palestine · Accepted Answer · 2014-04-25 11:50:27Z

6

This should be:

private $validationCallback;

public function __construct(){
    $this->validationCallback = function($credential, $passwordHash)
{
    if (has('md5', $credential) === $passwordHash) {
        return true;
    }
    return false;
}; // Missing semicolon needs to be here
}

Please see PHP's Anonymous Function documentation:

Closures can also be used as the values of variables; PHP automatically converts such expressions into instances of the Closure internal class. Assigning a closure to a variable uses the same syntax as any other assignment, including the trailing semicolon:

answered Apr 25, 2014 at 11:50

Brandon - Free Palestine

16.7k12 gold badges60 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nadeem Khan · Accepted Answer · 2014-04-25 11:47:27Z

3

Anonymous functions need a semicolon at the end. Try this:

private $validationCallback;

public function __construct(){
$this->validationCallback = function($credential, $passwordHash)
{
if (has('md5', $credential) === $passwordHash) {
    return true;
}
return false;

};
}

answered Apr 25, 2014 at 11:47

Nadeem Khan

3,4341 gold badge34 silver badges44 bronze badges

Collectives™ on Stack Overflow

Unexpected PHP Parse Error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related