PHP Dom Getting Multiple href From Class

Question

Could someone please help me out.

I'm trying to get multiple href's from a page for exmaple.

The page

<div class="link__ttl">
    <a href="/watch-link-53767-934537" target="_blank" rel="nofollow">Version 1</a>
</div>
<div class="link__ttl">
    <a href="/watch-link-53759-934537" target="_blank" rel="nofollow">Version 1</a>
</div>

PHP Dom

$data = array();

$data['links'] = array();

$page = $this->curl->get($page);
$dom = new DOMDocument();
@$dom->loadHTML($page);

$divs = $dom->getElementsByTagName('div'); 
for($i=0;$i<$divs->length;$i++){   
    if ($divs->item($i)->getAttribute("class") == "link__ttl") {
        foreach ($divs as $div) {
            $link = $div->getElementsByTagName('a');
            $data['links'][] = $link->getAttribute("href");
        }
    }
}

But this don't same to work and i get a error

Call to undefined method DOMNodeList::getAttribute()

Could someone help me out here please thanks

$div->getElementsByTagName('a') gives you a DOMNodeList; not a DOMNode. You'll need to access an specific item of the DOMNodeList or iterate though its items. — user142162
– user142162, Commented May 11, 2014 at 19:52

Musa · Accepted Answer · 2014-05-11 20:08:47Z

1

You're testing divs for having the link__tt class, but then just for each all the divs. Take only the anchors from the divs that have the class.
Then you're trying to call getAttribute from a DOMNodeList, you need to get the underlying domnode to get the attribute.

$divs = $dom->getElementsByTagName('div'); 
for($i=0;$i<$divs->length;$i++){  
    $div = $divs->item($i);
    if ($div->getAttribute("class") == "link__ttl") {
            $link = $div->getElementsByTagName('a');
            $data['links'][] = $link->item(0)->getAttribute("href");
    }
}

Another solution is to use xpath

$path = new DOMXPath($dom);
$as = $path->query('//div[@class="link__ttl"]/a'); 
for($i=0;$i<$as->length;$i++){  
    $data['links'][] = $as->item($i)->getAttribute("href");
}

http://codepad.org/pX5qA1BB

edited May 11, 2014 at 20:08

answered May 11, 2014 at 19:58

Musa

97.9k17 gold badges123 silver badges144 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

TheHe · Accepted Answer · 2014-05-11 19:53:01Z

1

$link = $div->getElementsByTagName('a'); retrieves a LIST of Items where you cant's get an attribute-value "href" of...

try use of $link[0] instead of $link

answered May 11, 2014 at 19:53

TheHe

2,97221 silver badges24 bronze badges

Comments

ThW · Accepted Answer · 2014-05-12 17:23:16Z

0

Any part of a DOM is an node. The attributes are nodes, too, not just the elements. Using Xpath you can directly fetch an list of href attribute nodes.

$dom = new DOMDocument();
$dom->loadHtml($html);
$xpath = new DOMXpath($dom);

$result = [];
foreach ($xpath->evaluate('//div[@class = "link__ttl"]/a/@href') as $href)  {
  $result[] = $href->value;
}

var_dump($result);

Output: https://eval.in/150202

array(2) {
  [0]=>
  string(24) "/watch-link-53767-934537"
  [1]=>
  string(24) "/watch-link-53759-934537"
}

answered May 12, 2014 at 17:23

ThW

19.5k3 gold badges25 silver badges47 bronze badges

Collectives™ on Stack Overflow

PHP Dom Getting Multiple href From Class

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related