Same php markup of two link's "href" attribute, is outputting two different html

Question

The php template -

"home-pg-feed-video" => 
    "<div class=\"row home-pg-feed-item pl0 pr0 ml0 mr0\" data-type=\"video\">" .
        "<div class=\"col-lg-4 col-xs-4 pl0\">" .
            "<a href=\"/clinical-dialogue.php?v={{ url }}\"><img src=\"{{ thumb-sm }}\" alt=\"img\"/></a>" .
        "</div>" .
        "<div class=\"col-lg-8 col-xs-8 pr0 \">" .
            "<h4 class=\"mb5\">{{ title }}</h4>" .
            "<a href=\"/clinical-dialogue.php?v={{ url }}\" class=\"watch-link\">Watch the video</a>" .
            "<p>{{ summary }}</p>" .
        "</div>" .
    "</div>"

The link with "img" tag inside outputs correctly -

<a href="/clinical-dialogue.php?v=Dirk_Arnold_Patient_Selection_3rd_Line_&amp;_Sequencing_Final_Branded-video.php"><img src="images/vid_thumbs/sm/Dirk_Arnold_Branded.png" alt="img"></a>

But the second link of "watch video" outputs -

<a href="/clinical-dialogue.php?v={{ url }}" class="watch-link">Watch the video</a>

The markup where I am using the template

<div class="col-lg-8 col-xs-8 col-lg-feed">
                    <h3 class="feed-name mt0">Featured Clinical Dialogue</h3>
                    <?php
                        for($i = 0; $i < count($featureData); $i++){
                            $item = $featureData[$i];
                            if($item["type"] === "video"){
                                $template = $templates["home-pg-feed-video"];
                                $html = $template;

                                foreach($item as $key => $value){
                                    if($key == "topics") {
                                            $value = implode(", ", $value);
                                        }   
                                        $html = preg_replace("/{{ " . $key . " }}/", $value, $html, 1);
                                }
                                echo $html;
                            }
                        }
                    ?>
                </div>

cyberwombat · Accepted Answer · 2016-08-30 08:02:07Z

1

You have "1" in your preg_replace line which limits the number of matches (i.e. "url") to just 1. Use '-1' to not have a limit.

So

$html = preg_replace("/{{ " . $key . " }}/", $value, $html, -1);

Or

$html = preg_replace("/{{ " . $key . " }}/", $value, $html);

However in your case there is no need for regex. Use str_replace as it is faster:

$html = str_replace("{{ " . $key . " }}", $value, $html);

edited Aug 30, 2016 at 8:02

answered Aug 30, 2016 at 7:20

cyberwombat

40.6k43 gold badges190 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

Mahade Walid Over a year ago

Did not change anything. @yashua

cyberwombat Over a year ago

Weird. I just ran your template through the preg_replace with -1 and it worked.

Mahade Walid Over a year ago

Wierd indeed. What am I missing ... @yashua

Mahade Walid Over a year ago

"<p>{{ summary }}</p>" . Which comes after the link outputs correctly, but the link before the does not. @yashua

cyberwombat Over a year ago

With "1" as the limit I would expect all your replacement to work except for the second "url". Removing the "1" (or using -1) should effectively cause all {{ url }} to change. Try removing the first one from the template to see if the second one works and also to make sure there are no weird invisible characters in the {{ url }} expression try copying and pasting the first {{ url }} to the second one.

|

Collectives™ on Stack Overflow

Same php markup of two link's "href" attribute, is outputting two different html

1 Answer 1

13 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

13 Comments

Your Answer

Sign up or log in

Post as a guest

Related