Delete action not working in Rails - Parameter Missing

Question

I'm trying to add a delete action to my app, and I'm getting an odd error that I"m having trouble tracking down. It seems like the create action is being triggered even though I've assigned the button to the delete action. Based on the URL when I click on the delete button, it seems like it might be using GET, which I'm pretty sure isn't correct.

Any help is much appreciated!

Here's the error I'm getting when I click on a delete button in the index view.

class DogsController < ApplicationController
def create
    Dog.create(dog_params)

    @dogs = Dog.all
    redirect_to dogs_path
end

def new
    @dog = Dog.new
end

def edit
end

def delete
    @dog = Dog.find params[:id]
    @dog.destroy
    redirect_to dogs_path
end 

def show
    @dog = Dog.find params[:id]
end

def index
    @dogs = Dog.all
end

private

    def dog_params
        params.require(:dog).permit(:name, :breed)
    end
end

And here's the code for the index view:

<h1>List of Dogs</h1>

<table>
<thead>
    <tr>
        <td>Name</td>
        <td>Breed</td>
        <td>Details</td>
    </tr>
</thead>

<% @dogs.each do |d| %>
    <tr>
        <td><%= d.name %></td>
        <td><%= d.breed %></td>
        <td><%= d.id %></td>
        <td><%= link_to 'Details', dog_path(d.id) %></td>
        <td><%= link_to 'Edit', edit_dog_path(d.id) %></td>
        <td><%= button_to 'Delete', :method => :delete %></td>
    </tr>
<% end %>
</table>

Here's the example I was basing mine on; I didn't see a form associated with the delete action. Am I misinterpreting this? Thanks! — letsgoduke
– letsgoduke, Commented Jun 17, 2014 at 15:14

j-dexx · Accepted Answer · 2014-06-17 15:20:10Z

4

Rails will be looking for destroy not delete in your controller.

Change def delete to def destroy

Aha also noticed you're not specifying what you want to delete:

<%= button_to 'Delete', d, :method => :delete %>

Also in your create you're getting all Dogs then redirecting which is a waste, remove the @dogs = Dog.all query.

@dogs = Dog.all
redirect_to dogs_path

edited Jun 17, 2014 at 15:20

answered Jun 17, 2014 at 15:11

j-dexx

10.4k3 gold badges25 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

letsgoduke Over a year ago

Made the change, but still having the same issue. Thanks for the optimization tip as well.

j-dexx Over a year ago

What do you have in routes.rb and what do you see if you run rake routes?

j-dexx Over a year ago

Scratch that, updated answer. You've not set which object you want to delete.

letsgoduke Over a year ago

That did it! I was wondering if I needed to pass an ID or something, seemed odd. The example used "post" instead of something like "p", which explains why it wasn't working when I was using "dog". Thanks for the help!

Eyeslandic · Accepted Answer · 2014-06-17 15:23:00Z

0

button_to must pass in a parameter like this

button_to 'Delete', dog, method: :delete

answered Jun 17, 2014 at 15:23

Eyeslandic

14.9k13 gold badges44 silver badges55 bronze badges

Collectives™ on Stack Overflow

Delete action not working in Rails - Parameter Missing

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related