PHP - why displaying associative array using foreach is causing line gaps?

Question

This is my code to display my associative array

$i=1;
echo '<pre>';
foreach($bendetails as $bd)
{
    $i=str_pad($i,'2','0',pad_left);
    echo $i.'. '.$bd['cd2'].'<br />';
    echo $i.'. '.$bd['bban'].'<br />';
    $i++;
}
echo '</pre>';

when i am using print_r($bendetails); it's output is fine

Array
(
    [0] => Array
        (
        [cd2] => A=Add/U=Update/D=Delete
        )

    [1] => Array
        (
            [bban] => Bank Account Number
        )

    [2] => Array
        (
            [cd2] => A=Add/U=Update/D=Delete
        )

    [3] => Array
        (
        [bban] => Bank Account Number
        )

    [4] => Array
        (
            [cd2] => A=Add/U=Update/D=Delete
        )

    [5] => Array
        (
          [bban] => Bank Account Number
        )
)

and when I use above mentioned foreach to display it, I don't know from where, it is showing the output like

01 A=Add/U=Update/D=Delete
01 
02 
02 Bank Account Number
03 A=Add/U=Update/D=Delete
03 
04 
04 Bank Account Number
05 A=Add/U=Update/D=Delete
05 
06 
06 Bank Account Number

Can anyone please tell is there anything missing? What is causing these extra spaces. I am new to PHP arrays. Thanks in advance.

What you got is the expected result, having the shown array structure. — hek2mgl
– hek2mgl, Commented Jun 25, 2014 at 8:44
@hek2mgl - but it is showing extra lines, and i didn't want them... if u have downvoted the question, remove the down vote. i already said, i am NEW... — tushar.dahiwale
– tushar.dahiwale, Commented Jun 25, 2014 at 8:51
This has nothing to do with being NEW. Just use your eyes. However, @SyamMohan has already the right answer for you. — hek2mgl
– hek2mgl, Commented Jun 25, 2014 at 8:54

Syam Mohan M P · Accepted Answer · 2014-06-25 08:46:42Z

1

Change your array format like this

Array
(
  [0] => Array
    (
        [cd2] => A=Add/U=Update/D=Delete
        [bban] => Bank Account Number
    )

  [1] => Array
    (
        [cd2] => A=Add/U=Update/D=Delete
        [bban] => Bank Account Number
    )

  [2] => Array
    (
        [cd2] => A=Add/U=Update/D=Delete
        [bban] => Bank Account Number
    )

)

answered Jun 25, 2014 at 8:46

Syam Mohan M P

1,0679 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tushar.dahiwale Over a year ago

and how do i do that?

Christian P · Accepted Answer · 2014-06-25 08:43:47Z

0

Because your always printing both values, even if the keys do not exist. You should check that the key exists before printing:

foreach ($bendetails as $bd)
{
    $i=str_pad($i,'2','0', STR_PAD_LEFT);
    if (array_key_exists('cd2', $bd)){
        echo $i.'. '.$bd['cd2'].'<br />';
    }
    if (array_key_exists('bban', $bd)){
        echo $i.'. '.$bd['bban'].'<br />';
    }
    $i++;
}

answered Jun 25, 2014 at 8:43

Christian P

12.3k6 gold badges64 silver badges72 bronze badges

1 Comment

tushar.dahiwale Over a year ago

Thanks @Christian P.. duration is one minute only??? i have accepted your answer..

RiggsFolly · Accepted Answer · 2014-06-25 08:44:34Z

0

The correct use of the str_pad() function involves using a PHP CONSTANT called STR_PAD_LEFT and not just an arbitrary name pad_left so the padding command should be

$i=str_pad($i, '2', '0', STR_PAD_LEFT);

Maybe this is causing the unexplained odd spacing? Especially as the default padding is STR_PAD_RIGHT which is probably what you are being given.

answered Jun 25, 2014 at 8:44

RiggsFolly

94.7k22 gold badges108 silver badges152 bronze badges

Collectives™ on Stack Overflow

PHP - why displaying associative array using foreach is causing line gaps?

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related