PHP Blank lines on foreach loop

Question

I have a method which queries top 5 items from selected table and adds each row to a list. When i try to make an ordered list from this method, it lists 10 items not 5. One correct line and one blank line on each iteration. I've tried both a method in class and a function outside of the class but result is same.

Here is my method:

/**
* @return array
*/
public function top_list(): array {
    /* @var mysqli_result $result */
    $sql = "SELECT name FROM users ORDER BY performance DESC LIMIT 5";
    $result = self::$database->query($sql);
    if (!$result) {
        exit("Database query failed.");
    }
    $list = [];
    while ($record = $result->fetch_assoc()) {
        $list[] = $record;
    }
    $result->free();
    return $list;
}

and here is my ordered list:

$user = new User();
foreach ($user->top_list() as $item) {
    echo "<li>";
    echo $item["name"];
    echo "<li />";
}

Result of ordered list

print_r of $user->top_list()

Nick Tiberi · Accepted Answer · 2018-08-13 19:10:49Z

6

echo "<li />";

should be

echo "</li>";

You are not closing the list tag correctly, and the HTML renderer is attempting to create a new list item for each <li /> it sees.

answered Aug 13, 2018 at 19:10

Nick Tiberi

1,15112 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sercan Çelik Over a year ago

Thanks for your well explained help and i can't believe myself.

Nick Tiberi Over a year ago

You're welcome! No worries; it happens to the best of us. :-)

Collectives™ on Stack Overflow

PHP Blank lines on foreach loop

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related