linking error in Visual c++ when trying to inline functions

Question

When trying to inline a function in Visual C++ (2008 express), I got a linking error, after a close inspection of the code, what I discovered is that the function I am trying to inline throws an exception... if I remove the exception throwing, the linking error goes away, can someone explain why it is the case?

int com_ximpleware::FastIntBuffer::intAt(int index){
    if (index < 0 || index > size - 1) {
       throw InvalidArgumentException("invalid index range in FastIntBuffer's intAt()");
    }
    return ((int *) al->get(index>>exp))[index & r];
}

The exaxt error is shown below:

intHash.obj : error LNK2019: unresolved external symbol "public: int __thiscall com_ximpleware::FastIntBuffer::intAt(int)" (?intAt@FastIntBuffer@com_ximpleware@@QAEHH@Z) referenced in function __catch$?isUnique@IntHash@com_ximpleware@@QAE_NH@Z$0
1>C:\new_cvs\cpp_test1\Debug\cpp_test1.exe : fatal error LNK1120: 1 unresolved externals

One more thing, this function was invoked else normally, the calling part of the function wasn't included.

I put the definition (ie. implementation) in the header and there is no problem... do I have to move it into the header to inline it? I thought I can declare it as an inline function, no? — vtd-xml-author
– vtd-xml-author, Commented Mar 30, 2010 at 3:21
it's got to be visible wherever it is called, so generally it has to be in the header file. — Darryl
– Darryl, Commented Mar 30, 2010 at 3:33
Can you rephrase your last sentence? But weird, it seems it could not find com_ximpleware::FastIntBuffer::intAt from where it is called. — jasonline
– jasonline, Commented Mar 30, 2010 at 4:07
what I meant is that I declare the function using inline, and add definition in the .cpp file... is it clear? — vtd-xml-author
– vtd-xml-author, Commented Mar 30, 2010 at 4:41

jasonline · Accepted Answer · 2010-03-30 07:54:05Z

You'll have to place your definition in the header file.

An inline member function can be defined in two ways:

Define the member function in the class body itself.
Declare the member function just like a normal member function inside the class but when you define the inline member function, prepend the member function's definition with the keyword inline and put the definition into a header file, like the following:


class ClassA
{
public:
    void f();
};

inline void ClassA::f()
{
}

If you put the inline function's definition into a .cpp file and it if it is called from some other .cpp file, you'll get an "unresolved external" error (C++ FAQ Lite) from the linker.

I don't think it has something to do with the exception being thrown though. I could replicate this problem in Visual C++ 2005 even if the exception is not thrown.

My guess is that it was trying to inline the function but couldn't find its definition, since it was on a separate .cpp file. The compiler probably made some special processing because it recognized the inline keyword in the definition. If you remove the inline keyword, the problem disappears and linking is successful. Therefore, you need to place the definition together with its declaration in the header file, if you want it to be treated as inline.

Collectives™ on Stack Overflow

linking error in Visual c++ when trying to inline functions

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related