For loop reading empty variable

Question

I have a subroutine that runs in my batch file, during which I output to a textfile the success of each operation. An example is this...

set Tasks=One Two Three
set LogFile=Log.txt

for %%T in (%Tasks%) do call :Operation %%T

:Operation
set LogEntry=%1
echo %LogEntry%>> %LogFile%
goto :EOF

Using this I can get one, two and three written into the text file but I also get a final entry with an empty variable.

Can anyone see what the issue is?

MC ND · Accepted Answer · 2014-08-24 09:58:15Z

4

:operation is just a label. When the for command ends its work, the batch file continues its execution, enters the code after the label and the code inside it gets executed, but this time without any passed parameter.

Place a goto :eof or a exit /b after the for command to avoid it

set Tasks=One Two Three
set LogFile=Log.txt

for %%T in (%Tasks%) do call :Operation %%T
goto :eof    

:Operation
set LogEntry=%1
echo %LogEntry%>> %LogFile%
goto :EOF

answered Aug 24, 2014 at 9:58

MC ND

71.1k8 gold badges95 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3688529 Over a year ago

Great help! Very well observed and noted by myself! Thanks :)

Collectives™ on Stack Overflow

For loop reading empty variable

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related