How to fix array index out of bounds error?

Question

The error that I am getting

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 610
at Fib.sorted(Fib.java:67)
at Fib.main(Fib.java:17)

My code

public class Fib
{
    public static void main(String args[]) 
    {
        System.out.println(Arrays.toString( fiblist) );
        System.out.println(Fib.add());
        System.out.println(Fib.square());
        System.out.println(Fib.reversal());
        System.out.println(Fib.sorted());
    }

     public static int fiblist[] = {1,1,2,3,5,8,13,21,34,55,89,144,233,377,610,987,1597,2584,4181,6765};
     public static int fiblen = fiblist.length;

     public Fib() 
     {
        // Do nothing
     }

     public static ArrayList<Integer> sorted()
     {
         ArrayList sorted = new ArrayList();

         for(int counter = 0; counter < fiblist[4]; counter++ )
         {
             int temp1 = fiblist[counter];
             System.out.println("Elements stored " + temp1);
         }
         for(int counter = fiblist[14]; counter < fiblist[19]; counter++)
         {
             int temp2 = fiblist[counter];
             System.out.println("Last Elements stored " + temp2);
         }
         return sorted;
    }
}

I'm trying to store the last 5 elements of my array in temp 2. Then I will switch them. Is there an easier way to do this? Switch the first five elements of an array with the last five? How would you switch them with a for loop?

Your counter should be the position in the array and not the value of that position. Change counter < fiblist[4] to counter < 4 and change int counter = fiblist[14] to int counter = 14 to fix the problem. — Mike Laren
– Mike Laren, Commented Oct 1, 2014 at 19:39
This looks like trouble int counter = fiblist[14]; counter < fiblist[19]; since you are getting values way higher than your list size — gtgaxiola
– gtgaxiola, Commented Oct 1, 2014 at 19:39

Guillaume CR · Accepted Answer · 2014-10-01 19:40:13Z

2

You are confusing array index and value. fiblist[19] is 6765. You want your counters to go from 0 to 4 and 14 to 19, not fiblist[19].

for(int counter = 0; counter < 4; counter++ )
{
    int temp1 = fiblist[counter];
    System.out.println("Elements stored " + temp1);
}

for(int counter = 14; counter < 19; counter++)
{
    int temp2 = fiblist[counter];
    System.out.println("Last Elements stored " + temp2);
}

answered Oct 1, 2014 at 19:40

Guillaume CR

3,0361 gold badge21 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

bcsb1001 Over a year ago

Don't just copy and paste the OP's formatting and correct the problem with the code, fix the formatting so people don't have to edit both the question and your answer.

Brian Dela Cruz Over a year ago

This part runs. but how do I move temp1 to the end of an array? Or temp2 to the beginning of the array?

Guillaume CR Over a year ago

@vDc put fiblist[19] in a variable, set fiblist[19] = fiblist[0], then put the value of your variable in fiblist[0].

Skaros Ilias · Accepted Answer · 2014-10-03 08:51:56Z

1

This works

for(int i=0;i<fiblist.length;i++){
   System.out.print(fiblist[i]+",");
}
System.out.println();

for (int i=0;i<5;i++){
    temp=fiblist[i];
    fiblist[i]=fiblist[fiblist.length-i-1];
    //the first ellement= the last
    //the second=second from last...
    fiblist[fiblist.length-1-i]=temp;
}

for(int i=0;i<fiblist.length;i++){
    System.out.print(fiblist[i]+",");
}

Output:

1,1,2,3,5,8,13,21,34,55,89,144,233,377,610,987,1597,2584,4181,6765,
6765,4181,2584,1597,987,8,13,21,34,55,89,144,233,377,610,5,3,2,1,1,

edited Oct 3, 2014 at 8:51

answered Oct 1, 2014 at 19:46

Skaros Ilias

1,0821 gold badge13 silver badges41 bronze badges

1 Comment

Brian Dela Cruz Over a year ago

would temp just display the 'movement'?

cholewa1992 · Accepted Answer · 2014-10-01 20:23:00Z

0

Try this. It's a sorting algorithm (A fairly poor one though)

public static void sort(int[] a) {
    int iMin;
    int n = a.length;
    for (int j = 0; j < n-1; j++) {
        iMin = j;
        for (int i = j+1; i < n; i++) {
            if (a[i] < a[iMin]) {
                iMin = i;
            }
        }
        if(iMin != j) {
            swap(j, iMin, a);
        }
    }
}

public static void swap(int i, int j, int[] arr){
    int temp = arr[i];
    arr[i] = arr[j];
    arr[j] = temp;
}

edited Oct 1, 2014 at 20:23

answered Oct 1, 2014 at 19:45

cholewa1992

8931 gold badge7 silver badges16 bronze badges

Collectives™ on Stack Overflow

How to fix array index out of bounds error?

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related