Too many initializers for array in C++

Question

I am trying to initialize an array in Visual C++.

In my header file, I am declaring the array like this.
int pawnSquareTable[64];

In the cpp file where I include the header file, I am initializing the array in the constructor of the class in this manner:

pawnSquareTable[64]={0,0,1,2.....64 values};

However, VC++ is giving me a Too many initializer valueserror. Why is this happening?

EDIT:
The red squiggly line underlines the second element of the array.

It looks like you're trying to assign to an array. Please post an MCVE. — juanchopanza
– juanchopanza, Commented Oct 25, 2014 at 14:45
What is MCVE? I don't know that. Yes, I am trying to assign values in the constructor. — Rohit Shinde
– Rohit Shinde, Commented Oct 25, 2014 at 14:46
Your array size is 64 and you are probably initializing it more elements. — P.P
– P.P, Commented Oct 25, 2014 at 14:48

sp2danny · Accepted Answer · 2014-10-25 15:20:01Z

2

A::A()
    // : pawnSquareTable{1,2,3,4} // this would compile in clang/gcc
{
    // for MSVC, instead do this
    int* p = pawnSquareTable;
    for( int i : {1,2,3,4} ) // <- values here
        *p++=i;
}

answered Oct 25, 2014 at 15:20

sp2danny

7,7373 gold badges34 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Igor · Accepted Answer · 2014-10-25 15:10:52Z

2

When you have the code pawnSquareTable[64]={0,0,1,2.....64 values}; in your constructor, you are actually trying to set the value for the single element pawnSquareTable[64] (65th element of the array). The compiler expects to get an int and not an initializer-list, that's the reason for the error.

Instead of doing it, you should initialize the array in constructor's initialization list:

A::A() : pawnSquareTable{ 0, 1, 2 } //fill your values
{
}

edited Oct 25, 2014 at 15:10

answered Oct 25, 2014 at 14:52

Igor

27.4k28 gold badges93 silver badges114 bronze badges

3 Comments

Kevin Le - Khnle Over a year ago

No, that would be 65th element.

sp2danny Over a year ago

he's using Visual C++., it does not support explicit initializer for arrays

Rohit Shinde Over a year ago

I need to initialise around 5-6 arrays, and 5 constant variables. It will look ugly if I put them in the initialiser list. Is there any other method?

Collectives™ on Stack Overflow

Too many initializers for array in C++

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related