angularjs calling an inner function within service results in undefined

Question

I am new to angular. I have a service where I call a function by another function within the service. But in my controller is shows as undefined. See below

//my Service
myApp.service("LocationService", function() {
    var srv = {}
    srv.msg = {long:0, lat:0};

    srv.onSuccess = function() {
        this.msg.lat = 32;
    },

    srv.onError = function() {
        this.msg.long = 99;
    },

    srv.getGpsFix = function() {
        this.onSuccess();//fails in controller
    }

    return srv;
});

//my Controller
myApp.controller("MusicCtrl", ["$scope", "LocationService", function($scope, LocationService) {

//undefined
    console.log(locationService.getGpsFix());

}]);

Terminate your function assignments with semicolons. So instead of srv.onSuccess = function() { /* ... */ },, do srv.onSuccess = function() { /* ... */ };. — Jackson Ray Hamilton
– Jackson Ray Hamilton, Commented Feb 14, 2015 at 7:32
@Jackson I changed to semicolons at the end but I still get the undefined result. output of call console.log(LocationService.getGpsFix()); //undefined console.log(LocationService.msg); //lat is changed to 32 — Qammer Adil
– Qammer Adil, Commented Feb 14, 2015 at 7:44
Sure. I recommend that, in general, you use semicolons to terminate statements. My original suspicion was that that was the cause of the error, because frequently poor line termination is the cause of errors, but for this issue I think my posted Answer should help you. — Jackson Ray Hamilton
– Jackson Ray Hamilton, Commented Feb 14, 2015 at 7:46

Jackson Ray Hamilton · Accepted Answer · 2015-02-14 07:37:26Z

1

It is correct that locationService.getGpsFix() would return undefined.

If you intended for it to return a value, then use the return keyword in your function.

srv.getGpsFix = function() {
    this.onSuccess();
    return 'It worked!!!';
};

answered Feb 14, 2015 at 7:37

Jackson Ray Hamilton

9,5766 gold badges54 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DaProgrammer · Accepted Answer · 2015-02-14 07:40:57Z

1

locationService.getGpsFix() is undefined. In your controller, your service is available as LocationService. Hence, use LocationService.getGpsFix()

answered Feb 14, 2015 at 7:40

DaProgrammer

894 bronze badges

Collectives™ on Stack Overflow

angularjs calling an inner function within service results in undefined

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related