Validation on angular form

Question

I am receiving data into my my $scope as an object that contains various details of a client. I have the following models

client.name
client.email
client.programme

In my function I wish to ensure that every key has a value and nothing is left undefined.

I thought I could use || so go through each one and check for undefined within an if statement however this does not work.

for example:

$scope.addClient = function(newClient) {

console.log(newClient);

  if(!newClient.name ||!newClient.email) {
  $rootScope.$emit('errorEvent',
     {"message" : "You must enter some client name"} 
    );
  };

...performing other functions...

}

Secondly I would like to use a variable in the error message so that I can tailor it to the value that is undefined.

Mukund Kumar · Accepted Answer · 2015-04-23 22:23:03Z

1

you did not attach $scope to variable.

use this

    $scope.addClient = function(newClient) {

    if(!newClient){ 
       $rootScope.$emit('errorEvent',
         {"message" : "You must enter some client name"});
    }

    else if(!$scope.newClient.name || !scope.newClient.email) {
      $rootScope.$emit('errorEvent',{"message" : "You must enter some client name" });
     }
  }

or

$scope.addClient = function(newClient) {

     if(newClient && (!$scope.newClient.name || !scope.newClient.email) || !newClient ){ 
               $rootScope.$emit('errorEvent',
                 {"message" : "You must enter some client name"});
            }

          }

edited Apr 23, 2015 at 22:23

answered Apr 23, 2015 at 16:07

Mukund Kumar

23.5k20 gold badges64 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mukund Kumar Over a year ago

I think event propagation is not working.replace $emit to $broadcast.

Taylorsuk Over a year ago

I just get an error on !newClient.name cannot read property of undefined

Mukund Kumar Over a year ago

It mean that newClient is not define.please console in function and see , is it logs?

Taylorsuk Over a year ago

That is what I am trying to do... newClient will be undefined unless I enter something into the input.

Taylorsuk · Accepted Answer · 2015-04-24 08:27:53Z

0

I ended up having to do this:

    if(!client){ 
       $rootScope.$emit('errorEvent',
         {"message" : "You must enter a client name"});
    }

    else if(client.name === undefined) {
      $rootScope.$emit('errorEvent',{"message" : "You must enter a client name" });
     }

    else if(client.email === undefined ) {
      $rootScope.$emit('errorEvent',{"message" : "You must enter a client email" });
     }

    else { 

REST OF FUNCTION

}

Happy to receive constructive criticism / options to reduce this code...

answered Apr 24, 2015 at 8:27

Taylorsuk

1,4591 gold badge18 silver badges52 bronze badges

Collectives™ on Stack Overflow

Validation on angular form

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related