Calling a custom helper method in another helper throws syntax error

Question

I have a helpers folder in my project root (so, outside app/ folder). In my composer.json I autoload it:

"autoload": {
        "classmap": [
            "app/Http/Controllers",
            "app/Models",
            "database",
            "libraries",
            "helpers" // <- Helpers autoloaded here
        ],
       ...
    },

The methods of the helpers are static and they work properly in views and controllers. Now I'm trying to use one helper (Helper_1.php) in the second one (Helper_2.php), like so:

    class Helper_2 {

        protected static $value = Helper_1::getValue();
        ...

    }

but on the line where the $value field is declared, I get a error:

syntax error, unexpected '(', expecting ',' or ';'

I'm not sure why this happens. The syntax is obviously correct.

Update - Helper_1.php code:

class Helper_1 {

   public static function getValue() {
       $result = ''; 

       switch (Storage::getDefaultDriver()) {
            case 'local':
                $result= URL::to('/');
                break;

            case 's3':
                $path = Storage::getDriver()->getAdapter()->getClient()->getObjectUrl(env('S3_BUCKET'), '');
                break;
        }

        return $result.'/';
   }

}

you can accept answer for further readers if it was helpful :) — Limon Monte
– Limon Monte, Commented Jun 5, 2015 at 11:53

Limon Monte · Accepted Answer · 2015-05-19 09:34:02Z

3

PHP can't parse non-trivial expressions in initializers.

You can do this:

class Helper_2 {
    protected static $value;
}

Helper_2::$value = Helper_1::getValue();

or this:

class Helper_2 {
    protected static $value;

    static function init()
    {
        self::$value = Helper_1::getValue();
    }
}

Helper_2::init();

answered May 19, 2015 at 9:34

Limon Monte

54.8k49 gold badges191 silver badges222 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Martin Bean · Accepted Answer · 2015-05-19 09:36:52Z

3

The syntax is obviously correct.

It isn’t. You can’t use method calls in class property definitions, so the following is incorrect:

protected static $value = Helper_1::getValue();

You can only use simple data types like integers, strings, arrays etc.

answered May 19, 2015 at 9:36

Martin Bean

39.6k28 gold badges134 silver badges207 bronze badges

2 Comments

lesssugar Over a year ago

A man always learns. But I must say I wouldn't call the error thrown an informative one.

Martin Bean Over a year ago

@lesssugar No, but the error message is pretty literal: I guess the parser just isn’t intelligent enough to say, “Looks like the user’s trying to use a function/method call here, I best tell them that instead of saying I just found a random parenthesis.”

Collectives™ on Stack Overflow

Calling a custom helper method in another helper throws syntax error

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related