Rails 4 Integer number field returns string

Question

When I enter something into a number_field and post the form to the controller, Rails can't save because i have a numericality validation:

validates :rating, numericality: { greater_than: 0, less_than: 6 }

I debugged the controller by this piece of code:

raise "It exploded into pieces!" unless @comment.save

The exception I used for debugging said that my :rating was a string instead of an integer. Before this, i rendered the json errors for @comment and that said that :rating was not a number.

These are very useful to spot the problem, but I can't find any solutions to fix the problem. I checked the database schema and it says that :rating should be an integer, as in:

 t.integer  "rating"

I don't know what to do at this point. Can somebody help me? Thank you in advance.

P.S. I use number_field.

P.P.S. In my controller:

def ccreate
  @comment = Comment.new(params.permit(:rating, :body, :name, :game_id))
  raise "It exploded into pieces!" unless @comment.save
end

In my view:

<% if @comments.count < 10 %>
    <%= form_for(comment_path) do |f| %>
      <div class="field">
        <%= f.label :rating %><br>
        <%= f.number_field :rating %>
      </div>
      <div class="field">
        <%= f.label :body %><br>
        <%= f.text_area :body %>
      </div>
      <div class="field">
        <%= f.label :name %><br>
        <%= f.text_field :name %>
      </div>
      <div class="actions">
        <%= f.submit %>
      </div>
    <% end %>
<% end %>

I did that, same results. You are saying the validation hash, right Arslan? — ooransoy
– ooransoy, Commented Jun 17, 2015 at 11:29

Rene van Lieshout · Accepted Answer · 2015-06-18 06:01:38Z

3

It's a strong params thing. Permit :comments, then the attributes

params.require(:comments).permit(:rating, :body, :name, :game_id)

and, use form_for @comment, not comment_path

answered Jun 18, 2015 at 6:01

Rene van Lieshout

3721 silver badge4 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ooransoy Over a year ago

oh, @comment doesn't anymore

RichardAE · Accepted Answer · 2015-06-17 12:12:07Z

0

I think you need to setup the form properly, I think the validation will work fine if the form posts as it should:

comments_controller.rb

def new
  @comment = Comment.new
end

def create
  @comment = Comment.new(comment_params)
  raise "It exploded into pieces!" unless @comment.save
end

private

def comment_params
  params.require(:comment).permit(:rating, :body, :name, :game_id)
end

There we are changing the strong params to require the new comment key in params (which will be the result of the second change to the view below). I also moved this into a private function to clean this up.

So then in your view:

<% if @comments.count < 10 %>
    <%= form_for(@comment) do |f| %>
      <div class="field">
        <%= f.label :rating %><br>
        <%= f.number_field :rating %>
      </div>
      <div class="field">
        <%= f.label :body %><br>
        <%= f.text_area :body %>
      </div>
      <div class="field">
        <%= f.label :name %><br>
        <%= f.text_field :name %>
      </div>
      <div class="actions">
        <%= f.submit %>
      </div>
    <% end %>
<% end %>

This uses the form_for tag with the model instance which should, I think, solve this issue.

edited Jun 17, 2015 at 12:12

answered Jun 17, 2015 at 12:09

RichardAE

2,9701 gold badge20 silver badges20 bronze badges

7 Comments

RichardAE Over a year ago

I just updated the answer with a bit more detail on the changes I made.

ooransoy Over a year ago

undefined method `comments_path' for #<#<Class:0x007f9a46f0fae0>:0x007f9a46f0eed8> There is only #new in comments.

Arslan Ali Over a year ago

@avaragecoder Haven't you defined routes for comments?

RichardAE Over a year ago

Yes you need to add 'resources :comments, only: [:new, :create]' (no quotes) to your routes file. You can then add more methods to the only part as and when needed.

ooransoy Over a year ago

you see, my new function doesnt exist, comments are created in games#show, which goes to comments#create

|

didi · Accepted Answer · 2017-01-10 05:34:44Z

0

try this in the comment_controller.rb

@rating = params[:comment][:rating].to_i

to make every input of the ratings to be converted as integer

edited Jan 10, 2017 at 5:34

answered Jan 10, 2017 at 4:03

didi

12 bronze badges

Collectives™ on Stack Overflow

Rails 4 Integer number field returns string

3 Answers 3

1 Comment

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related