Rails 3: Why integer field is not validated against regex?

Question

Job model has an integer job_price field:

class CreateJobs < ActiveRecord::Migration
  def self.up
    create_table :jobs do |t|
      ...
      t.integer "job_price"
      ...
    end
  end
  ...
end

I would like to display an error message if user types strings in the job_price field, so I added the following validation:

class Job < ActiveRecord::Base 
  validates_format_of :job_price, :with => /\A\d{0,10}\z/, 
                      :message => "^Job Price must be valid"
  ...
end

However, it seems like the validation passes even when I type strings.

Any ideas why ?

Note

I had to add :value => @job.job_price_before_type_cast here:

f.text_field(:job_price, :maxlength => 10, 
             :value => @job.job_price_before_type_cast)

because, otherwise, if I was typing abc5, for example, and then submit the form, Rails was converted it to 5 (I guess because job_price is defined as integer).

Paul Schreiber · Accepted Answer · 2011-03-11 06:36:14Z

6

You could ensure it's an integer and in a range:

validates_numericality_of :myfield, :only_integer => true
validates_inclusion_of :myfield, :in => 0..9999999999

answered Mar 11, 2011 at 6:36

Paul Schreiber

12.6k4 gold badges44 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Steve Jorgensen Over a year ago

I'm finding that numeric values given for integer-type attributes seem to have already been rounded to integers prior to validation, so fractional entries are treated as valid, even when the :only_integer => true option is used.

Tombart · Accepted Answer · 2013-05-02 05:19:28Z

3

Rails 3 way would be:

validates :myfield, :numericality => { only_integer: true }
validates :myfield, :inclusion => { :in => 1..10000 }

answered May 2, 2013 at 5:19

Tombart

32.9k16 gold badges135 silver badges149 bronze badges

Comments

David Barlow · Accepted Answer · 2011-03-11 06:03:40Z

2

ActiveModel does have a built-in validation method for integers.

validates_numericality_of

Hopefully will behave how you want it to.

answered Mar 11, 2011 at 6:03

David Barlow

4,9841 gold badge31 silver badges24 bronze badges

Collectives™ on Stack Overflow

Rails 3: Why integer field is not validated against regex?

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related