jQuery Each function iterates over everything despite if statement

Question

The code appends the page URL after clicking specific links on the page. When I run the code, it performs as expected, appending the URL only to links that match the code. However, when I print to the console, I noticed that it appeared to do this for every single link on the page, despite the if statement that was supposed to limit it. When I took the if statement out, the code functioned the same. However, even though it works, I want to make it more efficient and only run on the links that match the parameters.

 // Function to change the link by adding the current page
 function setSlateLink() {
     // get the URL of the current page
     var currentPage = document.location.href;
     // get the URL of the slate
     var slateLink = jQuery('a[href$="code=magic"]').attr("href");
     // rewrite the slate, adding the query string with a key for Slate and value of the current page
     console.log("Processing link change");
     return slateLink += "&sys:interaction:summary=" + currentPage;

 }

 jQuery(document).ready(function() {

     jQuery("a").each(function(i, item) {
         // if there is an a tag, check that it ends like this
         if (jQuery(i == 'a[href$="code=magic"]')) {
             console.log("Found link: " + jQuery("a").attr("href"));
             // change the link to set the referrer (current page) in the URL
             jQuery('a[href$="magic"]').attr("href", setSlateLink());
             console.log("Changed link");
         }

     });
 });

Any idea what would cause this?

your if will always be true, because it evaluates to an empty jQuery collection — dandavis
– dandavis, Commented Jul 1, 2015 at 19:43
Code makes no sense, you are selecting the magic links on every iteration of the loop. SO you keep doing it over and over again to the same links — epascarello
– epascarello, Commented Jul 1, 2015 at 19:48

PhilVarg · Accepted Answer · 2015-07-01 19:56:49Z

4

you calling if (jQuery(i == 'a[href$="code=magic"]'))
this returns a jquery object which is truthy, causing the if statement to always execute.

if youre trying to see if that element matches the selector, you can use jquerys #is method:
if ($(item).is('a[href$="code=magic"]'))

edited Jul 1, 2015 at 19:56

answered Jul 1, 2015 at 19:45

PhilVarg

4,8303 gold badges22 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ryan Wheale Over a year ago

You should also provide a solution ;)

jthomas · Accepted Answer · 2015-07-01 20:08:58Z

2

Use is() to determine if an element would be matched by a selector. http://api.jquery.com/is/

Example:

if ($(item).is('a[href$="code=magic"]')) {
  // item matches
}

But you could simplify it by selecting those specific a tags to start with:

$('a[href$="code=magic"]').each(function(i, item) {
  // just code=magic links...
});

Going one step further...

$('a[href$="code=magic"]').each(function(i, item) {
  var href = $(item).attr('href');

  $(item).attr('href', href + '&sys:interaction:summary=' + document.location.href);
});

edited Jul 1, 2015 at 20:08

answered Jul 1, 2015 at 19:48

jthomas

8586 silver badges19 bronze badges

Collectives™ on Stack Overflow

jQuery Each function iterates over everything despite if statement

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related