17

How can I send the error messages that are happening in the model code back to the view. I mean. I have a

begin
       Some code
rescue
       Exception Handling
end

now error occurs and in the rescue, I would like to send a message back to the controller, so that it ll get displayed in the view. Do I have to use a variable, which has to contain a number of error messages that occurs in one request, concatenate them and send it back to controller, so that I can display it in the view?. Rails already shows some error messages like field can't be blank. I am asking about the other exceptions, which occurs in the functions that are present in the model code.

Improve this question

5 Answers 5

Reset to default
13

An example of what i do in my own code: 

def create
  @letter = Letter.new(params[:id])

  begin
    @letter.do_something_that_could_throw_an_exception
    flash[:notice] = I18n.translate('letter.success_create')
  rescue => e
    logger.error "letter_controller::create => exception #{e.class.name} : #{e.message}"
    flash[:error] = "#{I18n.translate('letter.letter_create_failed')}<br/>Detailed error: #{e.message}"
    ExceptionNotifier.deliver_exception_notification(e, self, request)
    # redirect somewhere sensible?
  end
end

end

Does that help?

Improve this answer
Sign up to request clarification or add additional context in comments.

Comments

7

Exceptions that happen as a part of saving/creating a model

I use the ActiveRecord callbacks after_validation, after_validation_on_create, and before_save (depending on the circumstance), to obtain any extra data and verify that everything is ready to be saved. Then, if any problems, I store the exception in errors[:base] using add_to_base. That way the view will display the error msg in the same way it displays any other validation errors.

Remember that if your before_save method returns false, the save will fail.

Exceptions for other model methods

All the usual methods are available:

  1. Raise a specific exception that the controller will catch. The exception can include an error number that the view translates to an error msg. Or the model can export an error_num to error_msg hash
  2. Return an error code as a return parameter of the method. Eg if you want to also use the Flash to give a positive msg when things work, you can return a msg_code. Then have negative msg codes for errors and positive codes for different types of success.
  3. Establish an @error (or whatever) instance variable to be checked by the caller.
Improve this answer

1 Comment

Given the OP's question I'm not sure that they'll understand your #3. Steve, I think what Larry means for 3 is adding something like attr_reader :error to the class definition, assigning it on error, and thus allowing the caller to retrieve it. But I think his #2 is probably the easiest to implement.
7 
begin
       Some code
rescue =>e
       @error= e.message
       Exception Handling
end

in views

<%= @error %>
Improve this answer

1 Comment

Note: this example will only work if the first code section is in the controller. If it is in the model, it won't work.
5

Set exception handler in ApplicationController

class ApplicationController < ActionController::Base

  rescue_from Exception, :with => :handle_exception

  def handle_exception(error)
    flash[:error] = error.message
    redirect_to request.referer || root_path
  end
end

This is general example, you can specify types of exception e.g. rescue_from ActiveRecord::RecordNotFound, ActiveRecord::RecordInvalid etc.

Improve this answer

5 Comments

But avoid rescuing Exception as it is the most generic exception type in Ruby see here why it is a bad practice: stackoverflow.com/questions/10048173/…
Of course, this is just an example - Exception should be handled with great care.
But this will only handle exceptions occurring in Controller. Not in views/helpers.
to the point of @BrunoPeres... this is fine just do StandardError instead of Exception
I think there is a typo: handle_exception needs to take error as an argument.
3 
begin
  some code
rescue StandardError => ex      
  flash[:error] = "#{ex}"
  render :index
end
Improve this answer

1 Comment

But avoid rescuing Exception as it is the most generic exception type in Ruby see here why it is a bad practice: stackoverflow.com/questions/10048173/…

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.