C Programming If Statements Not Working

Question

My if statements aren't working and I am not sure why. Can someone point out my error, thank you. This is just a kinda dumb program I am making just for practice, I am setting a lot more variables along the way.

#include <stdio.h>

main()
{

    //This is a program that determines what circle of hell the user will be put in.  Inspired by Dante's Divine Comedy
    char firstQuestion;

    float total = 0;

    printf("ABANDON ALL HOPE, YOU WHO ENTER HERE\n\n");
    printf("Welcome to the gate of hell. I am going to ask you a series of questions and you will answer them truthfully.\n\n\n");

    printf("I would first like to ask you, do you believe you are a good person?(Y or N)\n");
    scanf_s(" %c", &firstQuestion);
    if (firstQuestion == 'Y'){
        printf("We will see about that.\n");
        total = total + 10;
    }
    else if (firstQuestion == 'N'){
    printf("I'm not surprised.\n");
}
    return 0;

}

I am using Microsoft visual studio by the way. That is why my scanf() is scanf_s(). — Kevin Dunn
– Kevin Dunn, Commented Aug 14, 2015 at 7:28
You should query for =='Y' || ... =='y' because your inputs are case-sensitive — Tobias Knauss
– Tobias Knauss, Commented Aug 14, 2015 at 7:30
Also you might want to add an else-path that returns "invalid input" to the user... — Tobias Knauss
– Tobias Knauss, Commented Aug 14, 2015 at 7:32
For simple exercise programs you should rather use scanf which is not the same as scanf_s. See Nishant's answer below. — Jabberwocky
– Jabberwocky, Commented Aug 14, 2015 at 7:39

Nishant · Accepted Answer · 2015-08-14 07:32:51Z

5

scanf_s() is not a drop-in replacement for scanf(). You should include a buffer size when the input parameter is a character or string.

scanf_s(" %c", &firstQuestion,1);  //For single character

char s[10];

scanf_s("%9s", s, 10);    //For reading a string

answered Aug 14, 2015 at 7:32

Nishant

1,6651 gold badge11 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C Programming If Statements Not Working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related