If and if else statements working, but not else

Question

I am making a number guessing game program and am having some trouble with my else statements. In the main block where the number is trying to be guessed, the if and if else statements work, but the else statement does nothing. I am trying to make it where a number outside of the range 0 < number < 100 trigger the else statement.

Furthermore, I am trying to make the game repeat itself if '1' is entered but no matter what is entered, the program crashes.

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
    /*Number guessing game: The number that needs to be guessed is 52*/
    int guess;
    int attempt = 6;
    int playAgain = 1;

    printf("Guess the integer that I am thinking of between 1 and 100\n");
    printf("I will tell you if you guess too high or too low\n");
    printf("You have 6 attempts\n");
    printf("What is your first guess?\n");
    if (playAgain == 1)
    {
        while (attempt > 0)
        {

            scanf_s("%d", &guess);

            if (guess > 0)
            {
                if (guess < 52)
                {
                    attempt--;
                    printf("Sorry! Too low! You have %d more tries:\n", attempt);
                }
            }
            else if (guess <100)
            {
                if (guess > 52)
                {
                    attempt--;
                    printf("Sorry! Too high! You have %d more tries:\n", attempt);
                }
            }
            else if (guess == 52)
            {
                printf("Correct! You win!\n");
                attempt = 0;
            }

            else
            {
                printf("Invalid input: Please enter an integer between 1 and 100:\n");
            }
        }

        printf("Enter '1' to play again or anything else to terminate\n");
        scanf_s("%d", playAgain);
        attempt = 6;
    }

    else
        {
            printf("Thanks for playing!\n");
        }
    return 0;

}

For the sake of your own sanity, please use a consistent coding style and always indent in the same manner. If you indent with the tab key, ensure that the code editor is inserting spaces. — Lundin
– Lundin, Commented Mar 11, 2014 at 7:33
Also, while you are learning, use braces for every if/else. That (coupled with indenting along such lines) should help clarify what the code means. — user2864740
– user2864740, Commented Mar 11, 2014 at 7:34
you create two else but only one is possibel use an switch case or something like this — LFS96
– LFS96, Commented Mar 11, 2014 at 7:35
And if you still have a problem after implementing the two above suggestions - please let us know. Most likely that would be enough for you to figure out what's wrong. — oh whatever
– oh whatever, Commented Mar 11, 2014 at 7:35

Yabada · Accepted Answer · 2014-03-11 07:39:44Z

2

When you use if else if without brackets, make sure it can't be ambigous.

When you do :

if (true)
   if (true)
   {
   }
else if (false)
{
}

How to know if the else if correspond to the first or the second if ? That's why everyone yell at you to put brackets.

if (true)
{
   if (true)
   {
   }
}
else if (false)
{
}

answered Mar 11, 2014 at 7:39

Yabada

1,7581 gold badge16 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jabberwocky · Accepted Answer · 2014-03-11 09:35:27Z

Corrected and simplified version :

Your program crashes because you forgot the & sign inscanf("%d", &playAgain);.

The logic in your program is wrong, you intermix the test if the number is lower, equal or higher than the input with the test if the input is lower than 0 or higher than 100.

In this corrected version the "invalid input" problem is separated from the actuel "number guessing" problem.

Furthermore the number to be guessed (52) is nor longer hard coded but a variable numbertobeguessed is used instead. Later you should enhance the program so that a random number is generated.

int main(void)
{
  /*Number guessing game: The number that needs to be guessed is 52*/
  int numbertobeguessed = 52 ;
  int guess;
  int attempt = 6;
  int playAgain = 1;

  printf("Guess the integer that I am thinking of between 1 and 100\n");
  printf("I will tell you if you guess too high or too low\n");
  printf("You have 6 attempts\n");
  printf("What is your first guess?\n");

  if (playAgain == 1)
  {
    while (attempt > 0)
    {
      scanf_s("%d", &guess);

      if (guess < 0 || guess > 100)
      {
        printf("Invalid input: Please enter an integer between 1 and 100:\n");
      }
      else
      {
        if (guess < numbertobeguessed)
        {
          attempt--;
          printf("Sorry! Too low! You have %d more tries:\n", attempt);
        }
        else if (guess > numbertobeguessed)
        {
          attempt--;
          printf("Sorry! Too high! You have %d more tries:\n", attempt);
        }
        else
        {
          printf("Correct! You win!\n");
          attempt = 0;
        }
      }
    }

    printf("Enter '1' to play again or anything else to terminate\n");
    scanf_s("%d", &playAgain);
    attempt = 6;
  }
  else
  {
    printf("Thanks for playing!\n");
  }

  return 0;
}

LearningC · Accepted Answer · 2014-03-11 07:44:07Z

0

the else statement which gives message "Invalid input: Please enter an integer between 1 and 100:\n" is considered as the else part of inner most if-else-if statement. there fore that statement is never executed as the execution enters that if-else-if statement only if 0 < guess < 100. so use {} properly to make the proper combination of if-else statements.

answered Mar 11, 2014 at 7:44

LearningC

3,1621 gold badge15 silver badges19 bronze badges

Comments

Shomz · Accepted Answer · 2014-03-11 07:46:21Z

0

Your nesting is wrong. Put brackets for each if and else to make your code work (quickfix), and use proper indentation to make it readable to humans (if you wish).

Here's an example of how things can go wrong (pseudo code):

a = 4
if (a > 0)
    if (a < 3)
        a = 2
else
    a = 3

What do you expect is the end value of a?

Anyway, your:

if (guess > 0)
if (guess < 52)

should become this:

if (guess > 0 && guess < 52)

and your:

else if (guess <100) // this is where the problems start
if (guess > 52)

should become:

else if (guess < 100 && guess > 52)

and your code will work.

edited Mar 11, 2014 at 7:46

answered Mar 11, 2014 at 7:35

Shomz

37.7k4 gold badges61 silver badges87 bronze badges

Comments

Shine Jacob · Accepted Answer · 2014-03-11 08:28:16Z

hope this helps

#include <stdio.h>
#include <stdlib.h>

int main()
{
   int guess; //variable to hold the number from player
   int attempts = 6;
   char play = 'y';

   do
   {

    while(attempts)
   { 
     printf("\nEnter you guess: "); scanf("%d", &guess);

     attempts--;

     if(guess>0 && guess <100 )
     {
        if(guess>52)
          printf("\nThat's not it. Try something lower than that.");
        else if(guess<52)
          printf("\nThat's not the number. Try something higher than that.");
        else if(guess==52)
        { printf("\nYou got it!. You won the game."); 
          attempts = 0; //we're setting it to zero; we don't want the loop to run anymore
        }
     }
     else 
       printf("\nNumber enter is not in range!");
   }//end of while loop

     printf("\nDo you want to play again? (y/n): "); scanf("%c", &play);
   }while(play=='y' || play=='Y'); //run till player enter 'Y'
   return 0;
}

Collectives™ on Stack Overflow

If and if else statements working, but not else

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related