Problems in if else statements in C

Question

#include<stdio.h>
#include<stdlib.h>

int main(){

int month, day;
printf("Enter the input : ");
scanf("%d %d",&month,&day);

if (day == 1 &&  month==1 || month == 2 || month == 3 || month ==4){
    printf("Green\n");
}
else if(day == 2 && month == 5 || month == 6 || month ==7 || month ==8 ){
    printf("Red");
}

return 0;
}

In the above code whenever I choose d = 1 and month = 1-4 , it is supposed to print green which it does correctly. The problem is when I choose day = 2 & month = 8 or 7 or 6 it is supposed to print red but it is printing green. Am I missing something here?

Did you read this: en.cppreference.com/w/c/language/operator_precedence ? — Jabberwocky
– Jabberwocky, Commented Mar 22, 2022 at 15:40
Enclose the months in a paranthesis for clarity. (day == 1 && (month==1 || month == 2 || month == 3 || month ==4)) — जलजनक
– जलजनक, Commented Mar 22, 2022 at 15:41

Killar. exe · Accepted Answer · 2022-03-22 15:42:22Z

3

you need to check the day and month diffently. Try this instead:

if (day == 1 &&  (month==1 || month == 2 || month == 3 || month ==4)){
    printf("Green\n");
}
else if(day == 2 && (month == 5 || month == 6 || month ==7 || month ==8)){
    printf("Red");
}

answered Mar 22, 2022 at 15:42

Killar. exe

462 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Python learner · Accepted Answer · 2022-03-22 15:45:11Z

0

It just works fine as you expected.
Maybe, you forgot that your first input is month and day is second. Try again now.

#include <stdio.h> 
#include<stdlib.h> 
int main(){ 
int month, day; 
printf("Enter the input : "); 
scanf("%d %d",&month,&day); 
if ((day == 1 && month==1) || month == 2 || month == 3 || month ==4)
{ printf("Green\n"); } 
else if(day == 2 && month == 5 || month == 6 || month ==7 || month ==8 ){ 
printf("Red"); } 
return 0; 
}

answered Mar 22, 2022 at 15:45

Python learner

1,1631 gold badge11 silver badges20 bronze badges

8 Comments

Jabberwocky Over a year ago

This is plain wrong and your code indentation is terrible. You name suggests that you know that indentation is most important in Python. In C it's also important, but not for defining the program structure but for readability

Python learner Over a year ago

I just copied his code and paste it here. Since && has higher precedence than || operator parenthesis doesn't matter. It's just gives a warning not an error. And I believe input is provided reverse is the actual reason for this question.

Jabberwocky Over a year ago

Sorry, this answer is wrong, and your code formatting is terrible. The OP has accepted the other answer which is correct. Have a look at it. You probably misunderstood something.

Python learner Over a year ago

That's what I told you earlier(copy paste). You can take some time and read his question again. If your inputs are 7 and 2 it returns Green while Red is returned for 2 and 7. #Order of the inputs is the actual reason op to confuse*

John Bode Over a year ago

While input order does matter, this code still has issues; it will print "Green" if you enter 2 for the day and 4 for the month. The problem the OP is facing (and has acknowledged) is that && has higher precedence than ||, so the "Green" branch will be taken if month is 2, 3, or 4, regardless of the value of day. That's clearly not what the OP intends. Yeah, sure, this code produces the expected output for a specific set of inputs, but it doesn't produce expected outputs for all sets of inputs.

|

Collectives™ on Stack Overflow

Problems in if else statements in C

2 Answers 2

Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related