PHP cURL to many urls

Question

I have php a code and can't understand why the php script creates only 4 files, but without the data. If I use curl only for one url without foreach loop all will be ok. Any thoughts?

$years = array('2012', '2013', '2014', '2015');
foreach($years as $year)
{
    $url = "http://lpo.dt.navy.mil/data/DM/Environmental_Data_Deep_Moor_{$year}.txt";
    $fp = fopen(base_path() . "/database/rawdata/{$year}.txt", 'w');

    $curl = curl_init();
    curl_setopt_array($curl, array(
        CURLOPT_URL             => $url,
        CURLOPT_FILE            => $fp,
        CURLOPT_VERBOSE         => 1,
        CURLOPT_RETURNTRANSFER  => 1,
        CURLOPT_FAILONERROR     => 1
    ));

    curl_exec($curl);

    if (!curl_errno($curl))
    {
        $info = curl_getinfo($curl);
        Log::info("File created  {$year}.txt");
        Log::notice("Evaluation of this script was {$info['total_time']} seconds!");
    }
    else
    {
        Log::error("cURL ERROR " . curl_error($curl));
    }

    curl_close($curl);
    fclose($fp);
}

Where's the code that uses $fp ? you don't seem to have any code that handle the file write so why wouldn't it be empty? — Gal Sisso
– Gal Sisso, Commented Sep 12, 2015 at 14:05

uri2x · Accepted Answer · 2015-09-12 14:07:44Z

3

See joeterranova's comment on the PHP site:

It appears that setting CURLOPT_FILE before setting CURLOPT_RETURNTRANSFER doesn't work, presumably because CURLOPT_FILE depends on CURLOPT_RETURNTRANSFER being set

.

Therefore you should change your curl_setopt_array to the following:

curl_setopt_array($curl, array(
    CURLOPT_URL             => $url,
    CURLOPT_RETURNTRANSFER  => 1,
    CURLOPT_FILE            => $fp,
    CURLOPT_VERBOSE         => 1,
    CURLOPT_FAILONERROR     => 1
));

answered Sep 12, 2015 at 14:07

uri2x

3,1871 gold badge14 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP cURL to many urls

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related