Mongodb errors specific code handling

Question

I am trying to output specific messages on specific responses.

Here is my code:

.post(function(req, res) {
  var user = new User(req.body);

  user.save(function(err) {
    if(err) {
      if(err.code == 11000)
        res.status(409).json(customHTTPcodeReponses.exists(req.body.email));
    };

    User.findById(user._id, function(err, createdUser) {
      res.status(201).json(customHTTPcodeReponses.created(createdUser));
    });
  });
});

Flow:

Posting data. I get 201.
Posting same data again. I get 409.
Posting same data again. I get "Could not get any response (POSTMAN)"

Console error: _http_outgoing.js:335 throw new Error('Can\'t set headers after they are sent.'); [nodemon] app crashed - waiting for file changes before starting...

What could cause this?

I have changed description. Can you please look at it again? — be-codified
– be-codified, Commented Sep 19, 2015 at 12:13
Did you try adding the User.findById code within an else statement? (if(err){ .... } else { User.findById........ }) — shan1024
– shan1024, Commented Sep 19, 2015 at 15:34
@shan1024 thank you, I did not realised res can be called twice. I avoided this by typing in return as result of if(err). But I could use else statement as well. — be-codified
– be-codified, Commented Sep 21, 2015 at 15:14

shan1024 · Accepted Answer · 2015-09-21 17:41:32Z

1

Add the User.findById code within an else statement.

user.save(function(err) {
    if(err) {
      if(err.code == 11000)
        res.status(409).json(customHTTPcodeReponses.exists(req.body.email));
    }else{
        User.findById(user._id, function(err, createdUser) {
           res.status(201).json(customHTTPcodeReponses.created(createdUser));
        });
    }
  });

or add a return to the 1st response:

if(err.code == 11000)
    return res.status(409).json(customHTTPcodeReponses.exists(req.body.email));

answered Sep 21, 2015 at 17:41

shan1024

1,4298 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Mongodb errors specific code handling

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related