Time Conversion challenge on Hackerrank returning empty hour

Question

I was attempting the Time Conversion challenge on Hackerrank, but for some reason, the hour field in the 24-hour representation always comes out empty. Here's the challenge -

Problem Statement

Given a time in AM/PM format, convert it to military (24-hour) time.

Note: Midnight is 12:00:00AM on a 12-hour clock and 00:00:00 on a 24-hour clock. Noon is 12:00:00PM on a 12-hour clock and 12:00:00 on a 24-hour clock.

Another problem seems to be that the seconds always appears to be of 1 digit. For instance, if the input is 07:05:45PM, my Hackerrank output is :05:4.

But, the code runs just fine in IntelliJ on my desktop -

1:24:23AM
1
24
23AM
01:24:23

Process finished with exit code 0

and

07:05:45PM
07
05
45PM
19:05:45

Process finished with exit code 0

As there's no way to debug the solution on hackerrank itself, I'm not sure what's wrong. Here's my code -

package algorithms.Warmup;

import java.util.Scanner;

/**
 * Created by manishgiri on 1/6/16.
 */
public class TimeConversion {

    public static void main(String[] args) {
        Scanner in = new Scanner(System.in);
        String time = in.next();
        String[] parts = time.split(":");
        for(String part: parts){
            System.out.println(part);
        }
        int hours = Integer.parseInt(parts[0]);
        String minutes = (parts[1]);
        String[] last = parts[2].split("");

        String seconds = last[0]+last[1];
        String timeZ = last[2]+last[3];
        String finalHour = "";
        if(timeZ.equalsIgnoreCase("PM")) {
            if(hours == 12) {
                finalHour = Integer.toString(12);
            }
            else {
                finalHour = Integer.toString(hours + 12);
            }
        }
        else if(timeZ.equalsIgnoreCase("AM")) {
            if(hours == 12) {
                finalHour = "00";
            }
            else if(hours == 10 || hours == 11) {
                finalHour = Integer.toString(hours);
            }
            else {
                finalHour = "0"+hours;
            }
        }
        System.out.println(finalHour+":"+minutes+":"+seconds);


    }
}

Since there is no debug. You could replace the split for the last part AM and pm. You could just check if it String#contains AM or PM. Afterwards you could use String#replaceAll with the regex \\D. That way you would replace the AM and PM and would only have the seconds left. Maybe Hackerrank does a bad job with the split(""). Since it running for me either i can just an other way to solve it that might be working. — SomeJavaGuy
– SomeJavaGuy, Commented Jan 6, 2016 at 10:59

mpatel · Accepted Answer · 2018-02-27 09:10:15Z

2

Try the code below. Hope the comments will help to understand the logic.

static String timeConversion(String s) {
    // Split the string by :
    String[] sTime = s.split(":");

    int x = 0;

    // if PM and hours >12, add additional 12 to hours
    // for AM and hour = 12, set hour to 00
    if(sTime[sTime.length - 1].contains("PM") && !sTime[0].equals("12"))
        x = 12;

    String val1 = "";
    if(x == 12)
        val1 = (Integer.parseInt(sTime[0]) + x) + "";
    else {
        if(sTime[0].equals("12") && sTime[sTime.length - 1].contains("AM"))
            val1 = "00";
        else
            val1 = sTime[0];
    }

    // merge the string and return the result
    String result = val1 + ":" + sTime[1] + ":" + sTime[2].substring(0,2);
    return result;
}

Cheers!

answered Feb 27, 2018 at 9:10

mpatel

3482 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:33:05Z

1

I do not know why there is inconsistency between your JRE environment and Hackerrank environment. But if we came to your question, in hackerrank your code splits part[2] into 5 parts, leading empty string.

Which means if you update

String seconds = last[0]+last[1];
String timeZ = last[2]+last[3];

as

String seconds = last[1]+last[2];
String timeZ = last[3]+last[4];

it should run,

and to prevent initial empty string, there is some suggestions you can find below:

How to prevent java.lang.String.split() from creating a leading empty string?

edited May 23, 2017 at 12:33

CommunityBot

11 silver badge

answered Mar 17, 2016 at 15:44

Murat Güvenç

1211 silver badge5 bronze badges

Comments

avadhesh pareek · Accepted Answer · 2016-05-24 10:05:24Z

You can try this for hackerrank -

 public static void main(String[] args) {
        Scanner in = new Scanner(System.in);
        String time = in.next();
        int hours;
        String hrs = time.substring(0,2);
        hours = Integer.parseInt(hrs);
        String mins = time.substring(3,5);
        String secs = time.substring(6,8);
        String am_pm = time.substring(time.length()-2,time.length());
        if(am_pm.equalsIgnoreCase("PM") && !hrs.equalsIgnoreCase("12")){  
            hours += 12;
            hrs = Integer.toString(hours);
        }
        else if(am_pm.equalsIgnoreCase("AM") && hrs.equalsIgnoreCase("12")){
            hours = 0;
            hrs = "00";
        }
        System.out.println(hrs+":"+mins+":"+secs);
    }

Abdi · Accepted Answer · 2016-08-17 05:30:42Z

0

You can try this..

public static void main(String[] args) {
    Scanner in = new Scanner(System.in);
    String time = in.next();

    String[] sTime = time.split(":");

    int x = sTime[sTime.length - 1].contains("PM") ? 12 : 0 ;

    String val1 = (x == 12) ?  (Integer.parseInt(sTime[0]) + x) + "" :  (sTime[0].equals("12") ? "00" : sTime[0]);

    String result = val1 + ":" + sTime[1] + ":" + sTime[2].substring(0,2);
    System.out.println(result);
}

answered Aug 17, 2016 at 5:30

Abdi

11 bronze badge

Comments

Shiv Shankar · Accepted Answer · 2020-05-13 09:53:45Z

0

public static String timecon(String s) {
    System.out.println(s.substring(0, 2));
    int test = Integer.valueOf(s.substring(0, 2));
    if ((s.substring(0, 2).equals("12")) && s.substring(8, 10).equals("AM")) {
        return "00" + ":" + s.substring(3, 8);
    } else if (s.substring(0, 2).equals("12") && (s.substring(8, 10).equals("PM"))) {
        return s.substring(0, 8);
    } else if (s.substring(8, 10).equals("AM")) {
        return s.substring(0, 8);
    }
    else {
        return test + 12 + ":" + s.substring(3, 8);
    }

}

answered May 13, 2020 at 9:53

Shiv Shankar

111 bronze badge

Comments

Muhammad Amjad · Accepted Answer · 2020-06-19 13:52:39Z

0

You can try this in Java for Time Conversion Hackerrank

  /*
 * Complete the timeConversion function below.
 */
static String timeConversion(String s) {
    String h,m,sec;

    h = s.substring(0,2);
    m = s.substring(3,5);
    sec = s.substring(6,8);

    if(s.contains("PM") && !h.equals("12")){
        int inc = 12;
        inc += Integer.parseInt(h);
        h = inc + "";
    }
    if(s.contains("AM") && h.equals("12")){
        h = "00";
    }
    String milTime = h + ":" + m + ":" + sec;
    return milTime;
}

edited Jun 19, 2020 at 13:52

answered Jun 19, 2020 at 11:33

Muhammad Amjad

11 silver badge4 bronze badges

Comments

Rodrigo Freitas · Accepted Answer · 2021-06-07 03:54:20Z

0

Try this:

public static String timeConversion(String s) {

int h = Integer.parseInt(s.substring(0,2));

if (h == 12) h = 0;

if (s.substring(8,9).equals("P")) h = h + 12;

return String.format("%02d", h) + s.substring(2,8);

}

answered Jun 7, 2021 at 3:54

Rodrigo Freitas

1

Comments

user20093110 · Accepted Answer · 2022-09-26 18:14:55Z

0

public static string timeConversion(string s)
{
      var idate = DateTime.Parse(s);
      var odate = idate.TimeOfDay;
      return odate.ToString();
}

answered Sep 26, 2022 at 18:14

user20093110

1

Comments

Dilsher Balouch · Accepted Answer · 2022-10-24 11:55:09Z

0

the most compact code, i think

function timeConversion(s) {
    // Write your code here
    let time=s.slice(0,10).split(':');
    // return(time);
    if((time[0]<12)&&(time[2].includes('PM'))){
        time[0]=parseInt(time[0])+12;
    }
    if((time[0]==12)&&(time[2].includes('AM'))){
        time[0]='00';
    }
    // return(time);
    return(time.join(':').slice(0,8));
}

answered Oct 24, 2022 at 11:55

Dilsher Balouch

297 bronze badges

1 Comment

Community Over a year ago

Your answer could be improved with additional supporting information. Please edit to add further details, such as citations or documentation, so that others can confirm that your answer is correct. You can find more information on how to write good answers in the help center.

ipodtouch0218 · Accepted Answer · 2024-07-28 02:03:38Z

0

function timeConversion(s) {

    let split = s.split();
    let currenHour = s.slice(0, 2);

    let checkPm = split.filter((val) => val.includes("PM"));
    let checkAm = split.filter((val) => val.includes("AM"));

    if (checkPm != "") {
        if (currenHour != "12") {
            let newTime = Number(currenHour) + 12;
            let newArr = newTime.toString() + s.slice(2, 8);
            return (newArr);
        } else {
            return (s.slice(0, 8));
        }
    }
    if (checkAm != "") {
        if (currenHour != "12") {
            let newArr = s.slice(0, 8);
            return (newArr);
        } else {
            return ('00' + s.slice(2, 8,))
        }
    }
}

edited Jul 28, 2024 at 2:03

ipodtouch0218

3,4259 gold badges17 silver badges31 bronze badges

answered Jul 28, 2024 at 1:04

Farrukh Ahmad

13 bronze badges

Comments

aliaksei · Accepted Answer · 2019-11-17 13:59:49Z

-1

def timeConversion(s):
    # time_r=s[:-2]
    am_pm=s[-2:]
    if am_pm=='PM' and s[:2]!='12':
    s=str(int(s[:2])+12) + s[2:]
    if am_pm=='AM' and s[:2]=='12':
        s="00" + s[2:]
    return s[:-2]

print(timeConversion("07:05:45PM"))

edited Nov 17, 2019 at 13:59

aliaksei

7341 gold badge9 silver badges23 bronze badges

answered Nov 17, 2019 at 12:53

Aman Sawarn

113 bronze badges

Collectives™ on Stack Overflow

Time Conversion challenge on Hackerrank returning empty hour

11 Answers 11

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

11 Answers 11

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related