Why is my python program not working?

Question

import time
import random
target = random.randrange(1, 3, 2)
print target  #for debug reasons
time.sleep(5)
shot = raw_input("Enter a random number")
while shot != target:
   print "n0pe"
   shot = raw_input("Enter a random number")
else:
    print "you won"

as i was testing this funny game it just always said n0pe even if i was saying the right number. I cant figure out whats wrong with it!

Moshe · Accepted Answer · 2016-03-31 14:51:15Z

2

target is an integer value. raw_input() returns a string. In python, strings and integers will never be equal to each other.

For example:

print 1 == "1"
# prints "False"

You'll want to convert the user input to an integer using int() before doing the comparison.

import time
import random
target = random.randrange(1, 3, 2)
print target  #for debug reasons
time.sleep(5)
shot = int(raw_input("Enter a random number"))
while shot != target:
   print "n0pe"
   shot = int(raw_input("Enter a random number"))
else:
    print "you won"

edited Mar 31, 2016 at 14:51

answered Feb 12, 2016 at 19:14

Moshe

10k5 gold badges31 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Alon_G Over a year ago

THANKS I dont know why i didnt think of that ;D

Jumayel · Accepted Answer · 2016-02-12 19:17:36Z

0

The comparison is not right. You are comparing a string with integer.

Try this:

import time
import random
target = random.randrange(1, 3, 2)
time.sleep(5)
shot = raw_input("Enter a random number")
while True:
    if int(shot) != target:
        print "n0pe"
        shot = raw_input("Enter a random number")
    else:
        print "you won"
        break

answered Feb 12, 2016 at 19:17

Jumayel

964 bronze badges

Collectives™ on Stack Overflow

Why is my python program not working?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related