init UIView with custom parameters

Question

I'm trying to pass data to a custom uiview when initing. I followed the method outlined here.

My UIView

-(instancetype)initWithCoder:(NSCoder *)aDecoder
{
    if(self = [super initWithCoder:aDecoder])
    {
        [self initAudioPlayer];
    }

    return self;
}

- (void)initAudioPlayer
{
    self.player = [[AVAudioPlayer alloc]initWithContentsOfURL:self.fileURL error:nil];
    [self.player prepareToPlay];

}

My ViewController

- (void)viewDidLoad
{
    [super viewDidLoad];

    self.audioURL = [[NSBundle mainBundle] URLForResource:@"audio4" withExtension:@"wav"];
    AudioControlsView *view = [[[NSBundle mainBundle] loadNibNamed:@"AudioControlView"
                                                 owner:self
                                                options:nil] objectAtIndex:0];
    if (view)
    {    
            view.fileURL = self.audioURL;
    }
 [self.view addSubview:view];

}

When I do it this fileURL is nil.

I can get it to work with:

- (void)setFileURL:(NSURL *)fileURL
{
    _fileURL = fileURL;
    self.player = [[AVAudioPlayer alloc]initWithContentsOfURL:self.fileURL error:nil];
    [self.player prepareToPlay];
}

But I don't think that's the proper way.

As Dave says, the setter approach is correct. However one thing to note is you should make sure to stop the previous player (if there was one) before creating another in the setter. — Hamish
– Hamish, Commented Feb 14, 2016 at 22:52

Dave Batton · Accepted Answer · 2016-02-14 22:47:53Z

2

With the code you have now, -initAudioPlayer gets called before you set the fileURL.

I'd remove -initAudioPlayer and all of the init code. Your -setFileURL: accessor method is the correct approach.

answered Feb 14, 2016 at 22:47

Dave Batton

8,8451 gold badge48 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Vimy Over a year ago

Ok, thanks. I thought it wasn't the correct way of doing things.

Collectives™ on Stack Overflow

init UIView with custom parameters

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related