Replace entry in String Array

Question

I have a String Array with multiple entries in it. I want to transcribe this String Array into another one, replacing specific entries with a digit (k in this case). What I've tried so far:

public void replace(String[] eqh, char var, int maxX){
String[] holder = new String[eqh.length];
    String  comp = "";
    for (int k = -maxX/2; k <= maxX/2; k++){
        for (int i = 0; i< eqh.length; i++){
            if (eqh[i].equals(var)){
                holder[i] = ""+k; 
            } else {
                holder[i] = eqh[i];
            } 
            comp = Arrays.toString(holder);
            System.out.println("comp: "+comp);
        } 
/// some stuff with comp here
}

Unfourtunatley this is not working, the return for comp is exactly the same as the input from eqh.

You're changing holder (a variable that exists only in replace's scope), I don't see how eqh is affected. — Maroun
– Maroun, Commented Feb 25, 2016 at 13:21
You are comparing strings with chars in eqh[i].equals(var) (it will always return false). If you want to check whether first char is equals to var, do eqh[i].charAt(0) == var — andrucz
– andrucz, Commented Feb 25, 2016 at 13:22
eqh shouldnt be affected, because ill have to transcribe it multiple times — Zi1mann
– Zi1mann, Commented Feb 25, 2016 at 13:22

andrucz · Accepted Answer · 2016-02-25 13:29:10Z

3

You are comparing strings with chars in eqh[i].equals(var) (it will always return false). If you want to check whether first char is equals to var, do eqh[i].charAt(0) == var

Also, it is not a good practice to convert integers to strings doing ""+k. Use Integer.toString(k) or String.valueOf(k).

edited Feb 25, 2016 at 13:29

answered Feb 25, 2016 at 13:25

andrucz

2,0212 gold badges20 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

andrucz Over a year ago

You are welcome. Also check my advice about integers conversion.

zoom · Accepted Answer · 2016-02-25 13:26:13Z

1

You are trying to check if a String is equals to a char, the result of this test will always be false.

You can use eqh[i].indexOf(var) >= 0 to test if a String contains a char.

answered Feb 25, 2016 at 13:26

zoom

1,7762 gold badges16 silver badges27 bronze badges

Collectives™ on Stack Overflow

Replace entry in String Array

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related