Php form to email

Question

I cannot seem to get this to work properly, As far as i can see this is right? I might be doing it wrong but I am not sure, any help would be much appreciated

when i hit the submit button, nothing happens...

<div id="form" action="#" method="post"> <!-- form -->
<p class="form-title">Enquire Today!</p>
<p class="form-description">Lorem ipsum dolor sit amet, consectetur adipiscing elit. In quis congue lorem, quis posuere ex. Suspendisse interdum semper urna mollis eleifend. Donec vulputate imperdiet nisi sed eleifend. Mauris vulputate quam libero, vel efficitur odio suscipit vel. Etiam efficitur lacinia dictum.<br><br>Lorem ipsum dolor sit amet, consectetur adipiscing elit. In quis congue lorem, quis posuere ex. Suspendisse interdum semper urna mollis eleifend. Donec vulputate imperdiet nisi sed eleifend. Mauris vulputate quam libero, vel efficitur odio suscipit vel. Etiam efficitur lacinia dictum.</p>
<form class="form-left"> 
<p class="form-text">Name: <input type="text" name="name"></p>
<p class="form-text">Email: <input type="text" name="email"></p>
</form>
<form class="form-right">
<p class="form-text">Phone: <input type="text" name="phone"></p>
<p class="form-text">Company: <span class="form-margin"><input type="text" name="company"></span></p>
</form>
<a class="button-enquire" type="submit" name="submit" value="Submit" href="#form">Enquire Now!</a>
</div> <!-- form -->
<?php 
if(isset($_POST['Submit'])){
    $to = "placeholder";
    $from = $_POST['email'];
    $name = $_POST['name'];
    $email = $_POST['email'];
    $phone = $_POST['phone'];
    $company = $_POST['company'];
    $subject = " - Form submission - " . $email;
    $message = "Name: " . $name . "\n\n" . "Email: " . $email . "\n\n" . "Phone: " . $phone . "\n\n" . "Company: " . $company . "\n\n" . "Submitted form on the website, follow up with a call/email";
    $headers = "From:" . $from;
    mail($to,$subject,$message,$headers);

    }
?>

Thanks

Your HTML is completely wrong and you're checking for a POST request but a form without a method submits a GET by default. — j08691
– j08691, Commented Mar 10, 2016 at 17:42

Santosh Ram Kunjir · Accepted Answer · 2016-03-10 17:56:57Z

1

Check this it will give you basic idea how form works and you will get basic idea from following code and need more study how form works replace with your path phpfilename.php it will get php post values there. you have written method and action to div it will not work

<form id="form" action="phpfilename.php" method="post"> <!-- form -->
    <p class="form-title">Enquire Today!</p>
    <p class="form-description">Lorem ipsum dolor sit amet, consectetur adipiscing elit. In quis congue lorem, quis posuere ex. Suspendisse interdum semper urna mollis eleifend. Donec vulputate imperdiet nisi sed eleifend. Mauris vulputate quam libero, vel efficitur odio suscipit vel. Etiam efficitur lacinia dictum.<br><br>Lorem ipsum dolor sit amet, consectetur adipiscing elit. In quis congue lorem, quis posuere ex. Suspendisse interdum semper urna mollis eleifend. Donec vulputate imperdiet nisi sed eleifend. Mauris vulputate quam libero, vel efficitur odio suscipit vel. Etiam efficitur lacinia dictum.</p>

    <p class="form-text">Name: <input type="text" name="name"></p>
    <p class="form-text">Email: <input type="text" name="email"></p>


    <p class="form-text">Phone: <input type="text" name="phone"></p>
    <p class="form-text">Company: <span class="form-margin">
    <input type="text" name="company"></span></p>

    <button class="button-enquire" type="submit" name="submit" value="Submit" >Enquire Now!</button>
    </form>


    <?php 
    if(isset($_POST['Submit'])){
        $to = "placeholder"; // this is your Email address  
        $name = $_POST['name'];
        $email = $_POST['email'];
        $phone = $_POST['phone'];
        $company = $_POST['company'];
        $subject = " - Form submission - " . $email;
        $message = "Name: " . $name . "\n\n" . "Email: " . $email . "\n\n" . "Phone: " . $phone . "\n\n" . "Company: " . $company . "\n\n" . "Submitted form on the website, follow up with a call/email";
        $headers = "From:" . $from;
        mail($to,$subject,$message,$headers);

        }
    ?>

edited Mar 10, 2016 at 17:56

answered Mar 10, 2016 at 17:44

Santosh Ram Kunjir

1,0821 gold badge13 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Praveen Kumar Purushothaman Over a year ago

So you didn't explain the issue, and didn't even say what's changed. Man!

Brendon Wells Over a year ago

Changing my code by following this made it work, Thanks!

Praveen Kumar Purushothaman Over a year ago

@BrendonWells Nice. Did you even consider reading my answer? :)

Praveen Kumar Purushothaman · Accepted Answer · 2016-03-10 17:46:49Z

1

Form elements are made for a reason. It is not just you can put anything.

<a class="button-enquire" type="submit" name="submit"
   value="Submit" href="#form">Enquire Now!</a>

The above code is not a form element. Kindly replace it with either:

<button>
<input type="submit">

And it should work. Also, never ever check with isset($_POST["submit"]), as it is not reliable.

Finally your code should be:

<input class="button-enquire" type="submit" name="submit" value="Submit" />

Also make sure you replace your action attribute to the place where you are POSTing the stuff:

<form id="form" action="phpfilename.php" method="post">

And most important thing, please have only one <form> element. It looks like you are having multiple and nested <form> elements, which is invalid HTML. And most important, you have given the method and action to the <div>, where it doesn't even care those attributes.

edited Mar 10, 2016 at 17:46

answered Mar 10, 2016 at 17:41

Praveen Kumar Purushothaman

167k27 gold badges215 silver badges261 bronze badges

9 Comments

user2917245 Over a year ago

how should I check if there is something in the variable/does it exist if not with isset() ?

Praveen Kumar Purushothaman Over a year ago

@ksno A lot of ways: count($_POST), isset($_POST["name"])... Should I say everything?

user2917245 Over a year ago

> Also, never ever check with isset($_POST["submit"]), as it is not reliable. Why did you say that ?

Praveen Kumar Purushothaman Over a year ago

@ksno I asked you to search: stackoverflow.com/questions/7775512/…, stackoverflow.com/questions/3337682/…, vbforums.com/…, etc...

user2917245 Over a year ago

I mean if you code you form correctly, not like in those questions you listed. why isnt it reliable to check if form is being submitted?

|

Lajos Arpad · Accepted Answer · 2016-03-10 17:49:58Z

0

If you want to send a form with post method, then you need to set its method, like this:

<form action="target.php" method="post">
<!-- form elements -->
</form>

If you want to make sure you send something to your php backend, then you need to have input with name and value inside the form, like this:

<input type="submit" name="Submit" value="foobar">

The name will be the key and the value will be the value on server-side.

answered Mar 10, 2016 at 17:49

Lajos Arpad

80.4k42 gold badges123 silver badges235 bronze badges

Collectives™ on Stack Overflow

Php form to email

3 Answers 3

3 Comments

9 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related