Cakephp 3 best coding practice for model functions

Question

I have a current_day_users table and users table.What is the better coding practice between the following to extract data from current_day_users:

1.UsersTable.php code

   $this->CurrentDayUsers->find()->where(['user_id'=>$userId,'created'=>$dateToday])->first();

CurrentDayusersTable.php code

public function findUser($userId,$date){
    return  $this->find()->where(['user_id'=>$userId,'created'=>$date])->first();
}

Indrasis Datta · Accepted Answer · 2016-03-20 12:24:48Z

0

If you already have CurrentDayUsers table, I'd suggest you to follow the second approach:

public function findUser($userId,$date){
   return  $this->find()->where(['user_id'=>$userId,'created'=>$date])->first();
}

This is provides a clean and compact code instead of using the query builder within Users Table.

answered Mar 20, 2016 at 12:24

Indrasis Datta

8,6182 gold badges18 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Answer 1