Save an array of ActiveRecords objects

Question

I'm trying to save an array of ActiveRecords in my controller, but this error is showing up:

undefined method 'save' for #<Array:...>

I have this method of model:

def self.import(file)
  reservations = []
  CSV.foreach(file, headers: true ) do |row|
    room_id = Classroom.where(code: row[0]).pluck(:id).first
    row[0] = room_id
    reservations << Reservation.new(number_of_guests: row[1], check_in_date: row[2], check_out_date: row[3], room_id: row[0])
  end
  reservations
end

And I have this following controller:

def create_import
  @reservations = Reservation.import(params[:file].path)
  respond_to do |format|
    if @reservations.save
      format.html { redirect_to @reservation, notice: 'Reservations was successfully created.' }
      format.json { render :show, status: :created, location: @reservation }
    else
      format.html { render :import }
      format.json { render json: @reservations.errors, status: :unprocessable_entity }
    end
  end
end

How can I do this save method? I want to show a report with errors in my view.

Should Classroom.where(code: row[0]).pluck(:id) be Classroom.where(code: row[0]).pluck(:id).first??? The first one will give you the room_id wrapped in an array. — br3nt
– br3nt, Commented Jun 19, 2016 at 23:32

souslov · Accepted Answer · 2016-06-19 23:26:39Z

2

Well, you should call save method on each of them:

@reservations.each(&:save)

Or install some third party gem that provides a multiple insert feature. You should also rewrite your if statement, since the expression above will always return the collection itself, thus evaluating to true.

answered Jun 19, 2016 at 23:26

souslov

44.7k11 gold badges92 silver badges113 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

gumaro Over a year ago

So if I use this method, how can I return all the errors to my view?

souslov Over a year ago

@gumaro: you can use reject or select instead of each to collect instances that failed or succeeded to be saved.

br3nt Over a year ago

records_with_errors = @reservations.reject {|r| r.save }

br3nt Over a year ago

This is all in the create_import action. So, your success condition where all reservations are successfully imported is if there are no records with errors. That happens when reservations_with_errors.empty? returns true. If you want to check if there are errors, you can use reservations_with_errors.any? instead.

souslov Over a year ago

@gumaro: then you can use partition method instead of select/reject, which should give your two collections, the one that has proceeded to the db, and the one that has failed save method.

|

Collectives™ on Stack Overflow

Save an array of ActiveRecords objects

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related