Express : Calling functions on app.param in multiple routes with same para name

Question

I have 2 routes defined in 2 separate files but a parameter RecordId is same for both the routes:

I am expecting that : 1) whenever I call /api/CountryMaster/:RecordId, only RecordByIdCtry function should be called. &

2) when I am calling /api/commonMaster/:MasterName/:RecordId, only RecordByIdCmn function should be called.

However, both functions are getting called with the order being as set in javascript. i.e.

 require('../app/routes/commonMaster.server.routes.js')(app);
    require('../app/routes/countryMaster.server.routes.js')(app);

How can i stop these & ensure that only one method is called.

//CountryMaster.js

var ctrl = require('../../app/controllers/CountryMaster.server.ctrl.js');
var users = require('../../app/controllers/user.server.ctrl.js');
module.exports = function (app)
{

    app.route('/api/CountryMaster')
    .get(users.requiresLogin,ctrl.list) 
    .post(users.requiresLogin,ctrl.create);


     app.route('/api/CountryMaster/:RecordId')
    .get(ctrl.read)
    .put(users.requiresLogin, ctrl.hasAuthorization, ctrl.update)
    .delete(users.requiresLogin, ctrl.hasAuthorization, ctrl.delete);

    app.param('RecordId', ctrl.RecordByIdCtry);
}

//CommonMaster.js

var ctrl = require('../../app/controllers/commonMaster.server.ctrl.js');
var users = require('../../app/controllers/user.server.ctrl.js');
module.exports = function (app)
{
    app.route('/api/commonMaster/:MasterName')
    .get(users.requiresLogin,ctrl.list) 
    .post(users.requiresLogin,ctrl.create);
    app.route('/api/commonMaster/:MasterName/:RecordId')
    .get(ctrl.read)
    .put(users.requiresLogin, ctrl.hasAuthorization, ctrl.update)
        .delete(users.requiresLogin, ctrl.hasAuthorization, ctrl.delete);
    app.param('MasterName', ctrl.MasterName);
    app.param('RecordId', ctrl.RecordByIdCmn);
}

How can I ensure that only one method is called..

robertklep · Accepted Answer · 2016-06-20 11:44:41Z

1

In your code, app is always the same app, so you're basically declaring two handlers for the same parameter, which isn't going to work.

You should use entirely separate routers instead:

// CountryMaster.js
...
module.exports = function(app) {
  var router = require('express').Router();

  router.route('/')
        .get(...)
        .post(...);

  router.route('/:RecordId')
        .get(...)
        .put(...)
        .delete(...);

  // The magic:
  router.param('RecordId', ctrl.RecordByIdCtry);

  // Mount the router on `/api/CountryMaster`
  app.use('/api/CountryMaster', router);
};

And similar for CommonMaster.js.

answered Jun 20, 2016 at 11:44

robertklep

205k38 gold badges421 silver badges413 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Express : Calling functions on app.param in multiple routes with same para name

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related