Django not serving media files if I check for settings.DEBUG

Question

This serves the media files correctly:

urlpatterns = [
...
] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)

This doesn't serve the media files:

from django.conf import settings
from django.conf.urls.static import static

urlpatterns = [ ... ] 

if settings.DEBUG:
    urlpatterns + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)

The documentation writes "This is not suitable for production use!", so that is why I need a way to check for DEBUG before serving media files. How can I do that. Why does this approach doesn't work?

development server is running in one or two threads, so it's thruput is very limited, so you request are served one-by-one - slowly, plus each static file is being served using basic open-read-send-close operations, without any os advantages (e.g. sendfile, zero-copy) - check uwsgi - it is quite robust and works well with django — Jerzyk
– Jerzyk, Commented Jul 14, 2016 at 16:17

rafalmp · Accepted Answer · 2016-07-14 16:12:54Z

8

Use

if settings.DEBUG:
    urlpatterns += static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)

(notice '=' after '+' - in your version you are adding static() patterns but not assigning the result to the urlpatterns variable)

answered Jul 14, 2016 at 16:12

rafalmp

4,0883 gold badges32 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Django not serving media files if I check for settings.DEBUG

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related