Replace part of a string with another string (missing first string)

Question

cin >> "You are very good."

#include <iostream>
#include <string>

using namespace std;

int main()
{
    string s;
    cin  >> s;

while (getline(cin, s))
{
    while (s.find("bad")!= string::npos)
         {
             s.replace(s.find("bad"), 3, "good");
         }
    cout << s << endl;

}
    return 0;
}

cout << "are very good."

Where is first word "You"? How should look correct code?

Barmar · Accepted Answer · 2016-08-18 16:10:40Z

2

cin >> s; before the loop is reading the first word of the line and removing it from the input stream. Then getline(cin, s) reads the rest of the line. So the first time through the loop, s is just are very bad. You then replace bad with good, and the result is are very good.

There doesn't seem to be any reason for the cin >> s; line, so just remove it.

answered Aug 18, 2016 at 16:10

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Replace part of a string with another string (missing first string)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related