Simple factory call giving error in AngularJs

Question

In a simple example, I am expecting console to ping me "USA". Instead I am getting an error. Can someone help fix it?

SNIPPET:

<html> 
<head> 
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.8/angular.min.js"></script> 
</head> 

<body ng-app="myApp" ng-controller="myCtrl"> 
<script>
//module declaration
var app = angular.module('myApp',[]);
//controller declaration
app.controller('myCtrl',function($scope, myFactory){
    var a = myFactory();
    console.log(a.country);
});

//factory declaration
app.factory('myFactory',function(){
    var obj = {};
    obj.country = "USA";
    return obj;
});
</script> 
</body> 
</html>

Error:

Jigarb1992 · Accepted Answer · 2016-09-26 13:34:11Z

1

try this

<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.8/angular.min.js"></script> 


<body ng-app="myApp" ng-controller="myCtrl"> 
<script>
//module declaration
var app = angular.module('myApp',[]);
//controller declaration
app.controller('myCtrl',function($scope, myFactory){
    var a = myFactory;
    console.log(a.country);
});

app.factory('myFactory',function(){
    var obj = {};
    obj.country = "USA";
    return obj;
});
</script> 
</body>

answered Sep 26, 2016 at 13:34

Jigarb1992

8482 gold badges19 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sascha10000 · Accepted Answer · 2016-09-26 13:27:08Z

0

As the runtime is telling you, myFactory is not a function.

var a = myFactory();

This call is therefore not valid. You can do this.

var a = myFactory;
console.log(a.country);

Or just:

console.log(myFactory.country);

answered Sep 26, 2016 at 13:27

sascha10000

1,2401 gold badge10 silver badges23 bronze badges

Comments

Ankit Solanki · Accepted Answer · 2016-09-26 13:30:00Z

0

    <html> 
<head> 
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.8/angular.min.js"></script> 
</head> 

<body ng-app="myApp" ng-controller="myCtrl"> 
<script>
//module declaration
var app = angular.module('myApp',[]);
//controller declaration
//factory declaration
app.factory('myFactory',function(){
    var obj = {};


    return {
        get: function(){
           obj.country = "USA";
            return obj;
        },

    }
});

app.controller('myCtrl',function($scope, myFactory){
    var a = myFactory.get();
    console.log(a.country);
});

</script> 
</body> 
</html>

answered Sep 26, 2016 at 13:30

Ankit Solanki

824 bronze badges

Comments

xkeshav · Accepted Answer · 2016-09-26 13:36:22Z

0

you can use the alternate way with $injector

//module declaration
var app = angular.module('myApp',[]);
//controller declaration
app.controller('myCtrl',function($scope, $injector){
    var a = $injector.get('myFactory')
    console.log(a.country);
});

//factory declaration
app.factory('myFactory',function(){
    var obj = {};
    obj.country = "USA";
    return obj;
});

answered Sep 26, 2016 at 13:36

xkeshav

54.2k47 gold badges183 silver badges256 bronze badges

Comments

Abdul Mateen Mohammed · Accepted Answer · 2016-09-26 14:25:52Z

0

You get the error because the factory returns a service object and you're trying to invoke it as a function.

Check the below code snippet.

angular
  .module('demo', [])
  .controller('DefaultController', DefaultController)
  .factory('demoFactory', demoFactory);

DefaultController.$inject = ['demoFactory'];

function DefaultController(demoFactory) {
  console.log(demoFactory.country);
}

function demoFactory() {
  var service = {
    country: 'USA'
  };
  
  return service;
}

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.23/angular.min.js"></script>
<div ng-app="demo">
  <div ng-controller="DefaultController as ctrl"></div>
</div>

answered Sep 26, 2016 at 14:25

Abdul Mateen Mohammed

1,8841 gold badge13 silver badges21 bronze badges

Collectives™ on Stack Overflow

Simple factory call giving error in AngularJs

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related