Windows 8.1 store apps OnCommandsRequested doesn't add ApplicationCommands when async used

Question

On the App.xaml.cs I have the following code

private async void OnCommandsRequested(SettingsPane settingsPane, SettingsPaneCommandsRequestedEventArgs e)
    {
        var loader = ResourceLoader.GetForCurrentView();

        var generalCommand = new SettingsCommand("General Settings", "General Settings", handler =>
        {
            var generalSettings = new GeneralSettingsFlyout();
            generalSettings.Show();
        });
        e.Request.ApplicationCommands.Add(generalCommand);

        object data;
        IAuthService _authService = new AuthService();
        if (Global.UserId == 0)
            data = await _authService.GetSettingValueBySettingName(DatabaseType.GeneralDb, ApplicationConstants.GeneralDbSettingNames.ShowSupportInfo);
        else
            data = await _authService.GetSettingValueBySettingName(DatabaseType.UserDb, ApplicationConstants.UserDbSettingNames.ShowSupportInfo);

        if (data != null && data.ToString().Equals("1"))
        {
            var supportCommand = new SettingsCommand("Support", "Support", handler =>
            {
                var supportPane = new SupportFlyout();
                supportPane.Show();
            });
            e.Request.ApplicationCommands.Add(supportCommand);
        }

        var aboutCommand = new SettingsCommand("About", loader.GetString("Settings_OptionLabels_About"), handler =>
       {
           var aboutPane = new About();
           aboutPane.Show();
       });
       e.Request.ApplicationCommands.Add(aboutCommand);

}

This code adds the setting "General Settings" but neither "Support" or "About" commands. Can anyone advice what's wrong with this code?

PS: All code executes successfully and no exceptions are throwing either. — SurenSaluka
– SurenSaluka, Commented Nov 11, 2016 at 8:48

Rob Caplan · Accepted Answer · 2016-11-12 21:39:09Z

1

Instead of querying the commands from your service when they are requested you'll need to query them ahead of time and then add the already known commands.

You cannot use await in OnCommandsRequested.

A method returns when it gets to the first await, so only commands added to the request before the await will be used.

Since the SettingsPaneCommandsRequestedEventArgs doesn't provide a deferral there is no way to tell the requester to wait for internal async calls to complete.

Note also that SettingsPane is deprecated and not recommended for new app development for Windows 10.

answered Nov 12, 2016 at 21:39

Rob Caplan

21.9k3 gold badges35 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Windows 8.1 store apps OnCommandsRequested doesn't add ApplicationCommands when async used

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related