LARAVEL : Destroy and detach method

Question

I'm trying to delete a Poll with this function where I need to detach relations :

public function destroy($id)
{
    $poll = Poll::findOrFail($id);
    $poll->answers()->detach();
    $poll->poll_user()->detach();
    $poll->delete();
}

But I'm getting this error message, I don't know why :

Call to undefined method Illuminate\Database\Query\Builder::detach()

Here is the Poll model :

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class Poll extends Model
{

    /**
     * La table utilisée par le modèle
     *
     * @var string
     */
    protected $table = 'polls';

    /**
     * On utilise les dates de mise à jour
     *
     * @var bool
     */
    public $timestamps = true;

    /**
     * Attributs autorisés en ensignement de masse.
     *
     * @var array
     */
    protected $fillable = ['question'];

    /**
     * Relation de type 1:n
     *
     * @return Illuminate\Database\Eloquent\Relations
     */
    public function answers()
    {
        return $this->hasMany('App\Models\Answer');
    }

    /**
     * Relation de type n:n
     *
     * @return Illuminate\Database\Eloquent\Relations
     */
    public function users()
    {
        return $this->belongsToMany('App\Models\User')->withTimestamps();
    }
 }

What is your poll/answers relationship? Can you post your Poll model? — CUGreen
– CUGreen, Commented Dec 28, 2016 at 10:29
What version of Laravel? You sure you don't need to use dissociate() instead of detach()? — CUGreen
– CUGreen, Commented Dec 28, 2016 at 10:34
I've tried also with dissociate, i get the same error : Call to undefined method Illuminate\Database\Query\Builder::dissociate(), version is 5.2.6 — Patrick Rey
– Patrick Rey, Commented Dec 28, 2016 at 10:39

Dessauges Antoine · Accepted Answer · 2019-11-05 18:49:38Z

3

/**
 * Removing an entity
 *
 * @param  integer $id
 * @return void
 */
public function destroy($id)
{
    $this->getById($id)->users()->detach();
    $this->getById($id)->answers()->delete();
    $this->getById($id)->delete();
}

/**
 * Getting an entity by id
 *
 * @param  integer $id
 * @return void
 */
public function getById($id)
{
    return Poll::find($id);
}

edited Nov 5, 2019 at 18:49

Dessauges Antoine

5936 silver badges28 bronze badges

answered Aug 13, 2019 at 6:08

Houssine Sghaire

334 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

barbsan Over a year ago

Could you translate these comments to english?

Patrick Rey · Accepted Answer · 2016-12-28 12:31:44Z

1

Well I don't know if it's correct or not but I've done the following and it works perfectly :

public function destroy($id)
{
    $poll = Poll::findOrFail($id);
    $poll->answers()->delete();

    $poll->users()->detach();
    $poll->delete();
}

answered Dec 28, 2016 at 12:31

Patrick Rey

1291 gold badge1 silver badge12 bronze badges

3 Comments

Patrick Rey Over a year ago

maybe it's because an answer cannot have a poll set with null. but the error message is not explicit...

CUGreen Over a year ago

As long as it works. Others might have more insight.

KvdLingen Over a year ago

This works because the Poll has a oneToMany relationship with the answers. Detach only works on manyToMany relationships like users()

CUGreen · Accepted Answer · 2016-12-28 12:22:35Z

0

Try the following code:

public function destroy($id)
{
    $poll = Poll::findOrFail($id);
    $poll->answers()->dissociate();
    $poll->users()->sync([]);
    $poll->delete();
}

If that doesn't work then might need to look at your other models or migrations.

edited Dec 28, 2016 at 12:22

answered Dec 28, 2016 at 12:13

CUGreen

3,2042 gold badges17 silver badges22 bronze badges

4 Comments

Patrick Rey Over a year ago

I've got the same xD : Call to undefined method Illuminate\Database\Query\Builder::sync()

Patrick Rey Over a year ago

well, it works without detaching the relations, but I think that's not correct at all

CUGreen Over a year ago

sorry, had sync on 1-m by mistake

CUGreen Over a year ago

So it works? Probably because you have cascade on delete? Depends on your migrations.

4lban · Accepted Answer · 2018-01-19 10:34:48Z

0

I suppose you set up connections in the right way in your models and I think you are trying to call this method in parent Controller (not in child Controller). Based on these this code should work...

public function destroy($id)
{
    $poll = Poll::findOrFail($id);

    foreach ($poll->answers as $answer) 
    {
        $answer->poll()->dissociate();
        $answer->save();
    }

    foreach ($poll->user as $user) 
    {
        $user->poll()->dissociate();
        $user->save();
    }

    $poll->delete();
}

answered Jan 19, 2018 at 10:34

4lban

1

Collectives™ on Stack Overflow

LARAVEL : Destroy and detach method

4 Answers 4

1 Comment

3 Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

3 Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related