javascript inside php - failing

Question

Here's my code in side of my php file:

        echo '<script type="text/javascript">';
        echo '<audio id="player" src="../cdh/ba1.mp3"></audio>';
        echo '<a onclick="document.getElementById('player').play()"><i class='fa fa-lg fa-volume-up'>';
        echo '</script>';

I was basing this off of Ionuț G. Stan's answer on How to output JavaScript with PHP and Sykox's answer on Single icon sound player in html using font awesome. I just took out the divs changed the src & i class.

The line giving me issues has got to be:

echo '<a onclick="document.getElementById('player').play()"><i class='fa fa-lg fa-volume-up'>';

which gives the error:

Parse error: parse error, expecting ','' or';''

What am I doing wrong?!

You need to escape the encapsulation quote type in your string. Look at the color highlighting of your question. In particular here getElementById(' — chris85
– chris85, Commented Jan 22, 2017 at 18:14
Possible duplicate of PHP Parse/Syntax Errors; and How to solve them? — chris85
– chris85, Commented Jan 22, 2017 at 18:14
Possible duplicate of How to escape a single quote ( ' ) in JavaScript? — CodeGodie
– CodeGodie, Commented Jan 22, 2017 at 18:23
I suggest using a good IDE so that these simple errors are caught: PHPStorm is a perfect choice — CodeGodie
– CodeGodie, Commented Jan 22, 2017 at 18:24

Abhishek · Accepted Answer · 2017-01-22 19:18:34Z

1

You have to escape single quotes inside.

echo '<a onclick="document.getElementById(\'player\').play()"><i class=\'fa fa-lg fa-volume-up\'></i></a>';

Or you can even use double quotes.

echo '<a onclick="document.getElementById("player").play()"><i class="fa fa-lg fa-volume-up"></i></a>';

PS: You have to close <a> tag as well.

Change your code to

echo '<a onclick="playAudio();"><i class=\'fa fa-lg fa-volume-up\'></i></a>'; 
echo '<script type="text/javascript">'; 
echo 'function playAudio(){var audio = new Audio("../cdh/ba1.mp3");'; 
echo 'audio.play();}'; 
echo '</script>';

The icon is not printing because it is under script tags.

edited Jan 22, 2017 at 19:18

answered Jan 22, 2017 at 18:16

Abhishek

1,0583 gold badges16 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Abhishek Over a year ago

please find updated code you forgot to close the <a> tag

Mou某 Over a year ago

awesomefont icon still not loading. ?~~?

Abhishek Over a year ago

have you included fontawesome library. with the limited code I just can't debug. share your full code

Abhishek Over a year ago

i tried executing it @MrLister but it doesn't give me any error. Can you please confirm again??

Mou某 Over a year ago

@Abhishek what's live? btw yes my FA lib is working fine before my <?php I have html code <li><a href="https://www.facebook.com"><i class="fa fa-lg fa-facebook"></i></a></li> that works absolutely a-ok

|

Collectives™ on Stack Overflow

javascript inside php - failing

1 Answer 1

9 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related