Event doesnt fired on the client using Node js and socket.io

Question

I have problems when i upload an image to my server, when i do that i want to emit this event to the room "1room"

 `io.sockets.in("1room").emit('image_added','OK');`

the problem is, the event doesnt fired on the client, but if i reload the page yes, the event is fired.

HTML

 <form ref='uploadForm' 
      id='uploadForm' 
      action='http://localhost:3000/upload' 
      method='post' 
      encType="multipart/form-data">
       <input type="file" name="sampleFile" />
       <input type='submit' value='Upload!' />
 </form>

SERVER

io.sockets.on('connection', function(socket){

   socket.join("1room");

});

    app.post('/upload', function(req, res) {

      if (!req.files)
        return res.status(400).send('No files were uploaded.');

      let sampleFile = req.files.sampleFile;

      sampleFile.mv('/xampp2/htdocs/pic.jpg', function(err) {

        if (err)
          return res.status(500).send(err);

     if (res.status(200)){
            io.on('connection', function(socket){
            io.sockets.in("1room").emit('image_added','OK'); 
    });

        }

      });

    });

CLIENT

socket.on('image_added', function(status) {

   alert(status);

});

Why are you using io.on('connection' again in the post request? — Ashkan Ghodrat
– Ashkan Ghodrat, Commented Mar 1, 2017 at 16:06
Also, Don't use Stackoverflow for question that can be fixed with a couple of more searches and or a little more effort. — Ashkan Ghodrat
– Ashkan Ghodrat, Commented Mar 1, 2017 at 16:10

jfriend00 · Accepted Answer · 2017-03-01 16:07:16Z

2

Change this:

 if (res.status(200)){
    io.on('connection', function(socket){
        io.sockets.in("1room").emit('image_added','OK'); 
    });
}

to this:

 res.status(200);
 io.sockets.in("1room").emit('image_added','OK');

You can't put an io.on('connection', ...) inside an app.post() nor would you ever want to. The event does not occur while that route is being processed. Instead, you just want to broadcast to all connection clients in that room with io.sockets.in("1room").emit('image_added','OK');

In addition, there's no point to if (res.status(200)) because that is always true since res.status() just returns the res object.

answered Mar 1, 2017 at 16:07

jfriend00

711k104 gold badges1.1k silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Remario · Accepted Answer · 2017-03-01 16:10:48Z

0

simple you are only sending if there is brand new connection event fire.

io.sockets.in("1room").emit('image_added','OK')

remove the connection event.

answered Mar 1, 2017 at 16:10

Remario

3,8612 gold badges22 silver badges25 bronze badges

Collectives™ on Stack Overflow

Event doesnt fired on the client using Node js and socket.io

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related