Javascript - Splitting number variable as a function

Question

Having some issues getting my head around this. I am trying to use a function to split a variable into two and then add a html  tag around each character. I have managed to do this process through a variable easy enough however when I try as a function it does not work.

<script>
var value = "30";

function myFunction(a) {
    var a = a.split("", 2);
    var a = "<span>" + a[0] + "</span><span>" a[1] + "</span>";
}

document.getElementById("demo").innerHTML = myFunction(value);</script>

Any hints as to why this might be?

kind user · Accepted Answer · 2017-03-08 17:02:38Z

1

You have to return a value from the function
You missed one + in the "" + a[0] + "" a[1] + "" line
If you want to split a word at every character, use empty quotation marks as the argument
You have used three a variables, overwriting each of them when declaring the new one

var value = "30";

function myFunction(a) {
    var b = a.split('');
    return "<span>" + a[0] + "</span><span>" + a[1] + "</span>";
}

document.getElementById("demo").innerHTML = myFunction(value);

<p id='demo'></p>

answered Mar 8, 2017 at 17:02

kind user

42k8 gold badges69 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sven Liebig · Accepted Answer · 2017-03-08 17:14:56Z

1

Since strings are arrays, you can do this:

var test = "1234";

function wrapSpans(a) {
    var tempStr = "";
    var x = 0;
    while(x < a.length) {
        tempStr += `<span>${a[x]}</span>`;
        x++;
    }
    return tempStr;
}

var value = "30";

document.querySelector("#demo").innerHTML = wrapSpans(test);

span {
  padding: 2px;
  background: yellow;
  margin: 2px;
}

div {
  padding: 2px;
  background: grey;
}

<div id="demo"></div>

edited Mar 8, 2017 at 17:14

answered Mar 8, 2017 at 17:03

Sven Liebig

8488 silver badges20 bronze badges

Comments

Abhinav Galodha · Accepted Answer · 2017-03-08 17:06:48Z

0

You are missing the + operator in the line
var a = "" + a[0] + "" a[1] + "";

It should be

var a = "" + a[0] + "" + a[1] + "";
You need to return a value from the function.
No need to redefine the var a again and again.

var value = "30";

function myFunction(a) {
    var a = a.split("", 2);
    a = "<span>" + a[0] + "</span><span>" + a[1] + "</span>";
    return a;
}

document.getElementById("demo").innerHTML = myFunction(value);

<div id="demo"></div>

answered Mar 8, 2017 at 17:06

Abhinav Galodha

9,9862 gold badges33 silver badges41 bronze badges

Collectives™ on Stack Overflow

Javascript - Splitting number variable as a function

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related