Javascript function, calls another function, but return false doesn't stop

Question

When I run this code it doesn't seem to be doing what I expect. So this is a validation, and when I run the if statement, the validator stops running when it hits the false. But when it hits the false from the other function numCheck, it alerts but then just continues. Since there are more validations below, if the numCheck comes back clean, how do I continue through the rest of the validation rather than cutting out if it's true? Where am I going wrong?

function numCheck(num){
	if(isNaN(num)){
		alert("Vendor number must be numeric");
		focusTo(document.forms["parts"]["vendorNo"]);
		return false;
	}
}

function validateForm(){
//DECLARATION
	var vendorNo = document.forms["parts"]["vendorNo"].value;
//VENDOR NUMBER
  numCheck(vendorNo);
	if(vendorNo.length != 4){
		alert("Please enter 4 digit Vendor Number");
		focusTo(document.forms["parts"]["vendorNo"]);
		return false;
	}

Thank you in advance, I've spent a lot of time trying to figure this out.

Robert I · Accepted Answer · 2017-04-03 21:11:40Z

1

You must also return from the parent (calling) function, validateForm

Your subroutine numCheck will return back to the calling function validateForm

function numCheck(num){
	if(isNaN(num)){
		alert("Vendor number must be numeric");
		focusTo(document.forms["parts"]["vendorNo"]);
		return false;
	}
return true;
}

function validateForm(){
//DECLARATION
	var vendorNo = document.forms["parts"]["vendorNo"].value;
//VENDOR NUMBER
  if (numCheck(vendorNo)==false){
     console.log("Invalid vendorNumber");
     return; // you must also return from the calling function, otherwise the code will still continue.
  }
	if(vendorNo.length != 4){
		alert("Please enter 4 digit Vendor Number");
		focusTo(document.forms["parts"]["vendorNo"]);
		return false;
	}

answered Apr 3, 2017 at 21:11

Robert I

1,5272 gold badges11 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AJ Funk · Accepted Answer · 2017-04-03 21:14:12Z

1

returning from numCheck does not mean validateForm has returned anything. Check the return value of numCheck and then take the appropriate action.

function validateForm(){
  ...
  // numCheck returns a boolean here. If it returns false, return from this function
  if(!numCheck(vendorNo)) {
    return false;
  }
 ....

answered Apr 3, 2017 at 21:14

AJ Funk

3,2071 gold badge18 silver badges18 bronze badges

Collectives™ on Stack Overflow

Javascript function, calls another function, but return false doesn't stop

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related